Page MenuHomePhabricator

Pywikibot use of $Id$ fails on git installed on Redhat boxen
Closed, DeclinedPublic

Description

When @Multichill and I were investigating T90156 at Lyon , git was showing one file as modified after a fresh clone of master. This was caused by git ident replacing $Id in bot.handle_args .

As a result, it is quite hard to develop on the Redhat system, as this additional change keeps being included.

IIRC, the git version was greater than 1.7.0.4 which is mentioned in bot.py .

One solution is to remove these idents from all files and the chunk of code supporting them in bot.handle_args. (T87409)

Another is to obfuscate the $Id in bot.handle_args even more so old versions of git cant recognise it.

Event Timeline

jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb added subscribers: Ricordisamoa, jayvdb, XZise and 3 others.
jayvdb set Security to None.

I guess, if you want to stick with this ident, you could use the ASCII codes for the characters? So for example '\\\x24\x49\x64' instead of r"\$Id".

Xqt subscribed.

I think this could be done with T87409 and no further work is to do then.