Upload wizard buttons are green
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Steinsplitter
	Jun 6 2015, 5:44 PM

Description

Some buttons at Special:UploadWizard are green. Please change (back?) to gray.

And something with the buttons seems wrong, they are too close to the text (T107508).
NOW:

BEFORE:

Details

	Subject	Repo	Branch	Lines +/-
	Add needed whitespace between buttons and text in UploadWizard	mediawiki/extensions/UploadWizard	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: rMEXT7d0c1512b955: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard…
rEUWI74be35dedd0c: Add needed whitespace between buttons and text in UploadWizard
Mentioned Here: T107508: UploadWizard file upload status runs into action button
T107779: No space between "Next" button and the "Skip this step in the future" checkbox label in Special:UploadWizard

Event Timeline

Steinsplitter created this task.Jun 6 2015, 5:44 PM

Steinsplitter raised the priority of this task from to High.

Steinsplitter updated the task description. (Show Details)

Steinsplitter added a project: UploadWizard.

Steinsplitter subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptJun 6 2015, 5:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Steinsplitter updated the task description. (Show Details)Jun 6 2015, 5:46 PM

Steinsplitter set Security to None.

Steinsplitter updated the task description. (Show Details)Jun 6 2015, 5:48 PM

I think they are green to conform with new button-standards, such as in the VE etc.

green is totally fine, good call for action.

In T101617#1344034, @Matanya wrote:

green is totally fine, good call for action.

well... this is point of view, but the blue button is attachet at the "!", All blur buttons in upload wiz are attached to text (whitespace in css missing)

In T101617#1344407, @Steinsplitter wrote:

the blue button is attachet at the "!", All blur buttons in upload wiz are attached to text (whitespace in css missing)

But how is that related to some different button being green now (which is what this task is about according to its task summary) which is likely intentional?
Or did you want to name this report "Applying button color changes seems to have made buttons and text too close" instead?

Plus I don't see how this is so urgent that it requires high priority - I'll leave that to the developers...

Some buttons at Special:UploadWizard are green.

This is according to the documentation in living style guide — Green is the color of constructive actions.

So I guess this is invalid (at least for UW) by definition? Closing.

If there are reasons to challenge the color, please reopen and elaborate and add the Codex project instead.

The buttons are still attached to the forms in FF, i am sure this isn't wanted. For example the "Continue" button is attached to the "!", there is missing a whitespace.

Josve05a renamed this task from Upload wizard buttons are green to Upload-buttons are attached to the forms in FF, missing whitespace.Jul 8 2015, 2:34 PM

Josve05a reopened this task as Open.

Josve05a updated the task description. (Show Details)

Josve05a edited projects, added Commons; removed Multimedia.

Restricted Application added a project: Multimedia. · View Herald TranscriptJul 8 2015, 2:34 PM

Josve05a renamed this task from Upload-buttons are attached to the forms in FF, missing whitespace to Upload-buttons are attached to the forms, missing whitespace.Jul 8 2015, 2:34 PM

Josve05a updated the task description. (Show Details)

Same thing in Chrome, there needs to be some sort of whitespace between the ! and the Continue-button.

MarkTraceur renamed this task from Upload-buttons are attached to the forms, missing whitespace to Upload step "All uploads complete!" text and "Upload" button are too close together.Jul 8 2015, 2:41 PM

Josve05a added a project: good first task.Jul 8 2015, 2:42 PM

MarkTraceur updated the task description. (Show Details)Jul 8 2015, 2:42 PM

Aklapper removed Aklapper as the assignee of this task.Jul 8 2015, 2:55 PM

zhuyifei1999 moved this task from Incoming to Uploading on the Commons board.Jul 9 2015, 5:57 AM

kaldari claimed this task.Aug 6 2015, 12:15 AM

Change 229607 had a related patch set uploaded (by Kaldari):
Add needed whitespace between buttons and text in UploadWizard

https://gerrit.wikimedia.org/r/229607

gerritbot added a project: Patch-For-Review.Aug 6 2015, 12:26 AM

kaldari updated the task description. (Show Details)Aug 6 2015, 12:55 AM

The title of the task was changed and re-opened :|
@kaldari, you might also want to see T107779: No space between "Next" button and the "Skip this step in the future" checkbox label in Special:UploadWizard and https://gerrit.wikimedia.org/r/#/c/229188/ (and all the patches it depends on.

With the current title, this is a duplicate of T107508. Since we have that filed as a separate bug, I'll revert this one to the original summary and resolution. Hope you don't mind, and sorry for not resolving the issue earlier.

matmarex renamed this task from Upload step "All uploads complete!" text and "Upload" button are too close together to Upload wizard buttons are green.Aug 6 2015, 10:47 AM

matmarex closed this task as Declined.

matmarex updated the task description. (Show Details)

matmarex removed projects: Patch-For-Review, good first task.

Change 229607 merged by jenkins-bot:
Add needed whitespace between buttons and text in UploadWizard

https://gerrit.wikimedia.org/r/229607

matmarex mentioned this in rEUWI74be35dedd0c: Add needed whitespace between buttons and text in UploadWizard.Aug 6 2015, 10:50 AM

kaldari mentioned this in rMEXT7d0c1512b955: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Aug 6 2015, 10:51 AM