Page MenuHomePhabricator
Create Task
Maniphest T101831

adaptable target link card is not shown when translating from an LTR language to an RTL language
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

To reproduce:

  • Translate the article "Mazoni" from Catalan to Hebrew.
  • Click the word "cantautor" (singer) in the first paragraph.

Expected: two link cards are supposed to be shown: One pointing to Cantautor in Catalan, and one pointing to זמר-יוצר in Hebrew.

Observed: In master, no link card is shown at all. In https://gerrit.wikimedia.org/r/#/c/216948/ , the source link is shown correctly, but instead of showing the target link, a "Missing link" card is shown.

More info:

  • If the target section is empty or no text selection and two link cards are shown with 'Add link' in target:
    • clicking add link should insert the target title text at cursor point.
  • If there is text selection, the link card works as usual with language pairs with MT or same directionality

Details

SubjectRepoBranchLines +/-
Bind link handlers to source links even if the target section is emptymediawiki/extensions/ContentTranslationmaster+13 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Amire80 created this task.Jun 9 2015, 1:06 PM
Amire80 raised the priority of this task from to High.
Amire80 updated the task description. (Show Details)
Amire80 added projects: ContentTranslation, RTL, LE-Sprint-88, ContentTranslation-Release5.
Amire80 subscribed.
Restricted Application added a project: I18n. · View Herald TranscriptJun 9 2015, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 moved this task from Backlog to Links on the ContentTranslation-Release5 board.Jun 9 2015, 1:06 PM
gerritbot subscribed.Jun 9 2015, 1:07 PM

Change 216948 had a related patch set uploaded (by Amire80):
Bind link handlers to source links even if the target section is empty

https://gerrit.wikimedia.org/r/216948

gerritbot added a project: Patch-For-Review.Jun 9 2015, 1:07 PM
• santhosh set Security to None.Jun 10 2015, 6:28 AM
• santhosh edited a custom field.
Amire80 added a parent task: T78695: Make it easy to add and edit links from scratch (tracking).Jun 10 2015, 7:13 AM
• santhosh subscribed.EditedJun 10 2015, 8:32 AM

If the target section is empty or no text selection and two link cards are shown with 'Add link' in target:

  • clicking add link should insert the target title text at cursor point.

If there is text selection, the link card works as usual with language pairs with MT or same directionality

Arrbee updated the task description. (Show Details)Jun 10 2015, 8:34 AM
• santhosh claimed this task.Jun 10 2015, 10:58 AM
• santhosh moved this task from Backlog to In Review on the LE-Sprint-88 board.
gerritbot added a comment.Jun 11 2015, 12:58 PM

Change 216948 merged by jenkins-bot:
Bind link handlers to source links even if the target section is empty

https://gerrit.wikimedia.org/r/216948

Amire80 mentioned this in rECTXbe9424f33c79: Bind link handlers to source links even if the target section is empty.Jun 11 2015, 12:58 PM
• santhosh mentioned this in rMEXT34694e155e1e: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Jun 11 2015, 12:58 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 11 2015, 1:01 PM
• Forrestbot subscribed.
Amire80 closed this task as Resolved.Jun 17 2015, 3:51 PM
Amire80 removed a project: Patch-For-Review.
Amire80 moved this task from In Review to Done on the LE-Sprint-88 board.Jun 17 2015, 3:55 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL