Page MenuHomePhabricator
Create Task
Maniphest T102041

[emergency] Banners not showing up on mobile in 1.26wmf9
Closed, ResolvedPublic
Actions

Description

As of today (2015-06-10) CentralNotice banners are not showing up on mobile devices on sites with 1.26wmf9 vs 1.26wmf8.

Compare banner display on commons (currently wmf9) vs wp (currently wmf8).

Details

SubjectRepoBranchLines +/-
Use the correct inner variable namemediawiki/extensions/MobileFrontendwmf/1.26wmf9+1 -1
Use the correct inner variable namemediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

AndyRussG created this task.Jun 10 2015, 8:11 PM
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG added projects: MediaWiki-extensions-CentralNotice, Fundraising Sprint Lou Reed.
AndyRussG subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2015, 8:11 PM
AndyRussG triaged this task as Unbreak Now! priority.Jun 10 2015, 8:13 PM
AndyRussG set Security to None.
AndyRussG added subscribers: K4-713, awight, Ejegg and 3 others.
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Lou Reed board.Jun 10 2015, 8:37 PM
gerritbot subscribed.Jun 10 2015, 8:56 PM

Change 217403 had a related patch set uploaded (by Awight):
Use the correct inner variable name

https://gerrit.wikimedia.org/r/217403

gerritbot added a project: Patch-For-Review.Jun 10 2015, 8:56 PM
gerritbot added a comment.Jun 10 2015, 9:06 PM

Change 217403 merged by jenkins-bot:
Use the correct inner variable name

https://gerrit.wikimedia.org/r/217403

awight mentioned this in rMEXT32f4909c8a13: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 10 2015, 9:06 PM
awight mentioned this in rEMFRcc8cc9b0c8db: Use the correct inner variable name.
AndyRussG moved this task from Doing to Pending Deployment on the Fundraising Sprint Lou Reed board.Jun 10 2015, 9:14 PM
• mmodell subscribed.Jun 10 2015, 9:18 PM

What's the status? Want me to deploy this or it can wait for SWAT?

AndyRussG added a comment.Jun 10 2015, 9:25 PM

If you'd like to deploy, that'd be fantastic!! Thanks so much :D

gerritbot added a comment.Jun 10 2015, 9:43 PM

Change 217417 had a related patch set uploaded (by 20after4):
Use the correct inner variable name

https://gerrit.wikimedia.org/r/217417

gerritbot added a comment.Jun 10 2015, 9:47 PM

Change 217417 merged by jenkins-bot:
Use the correct inner variable name

https://gerrit.wikimedia.org/r/217417

• mmodell mentioned this in rEMFR27406f41faac: Use the correct inner variable name.Jun 10 2015, 9:48 PM
AndyRussG closed this task as Resolved.Jun 10 2015, 10:22 PM
AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Lou Reed board.

Thanks all!!

• Forrestbot added projects: WMF-deploy-2015-06-09_(1.26wmf9), WMF-deploy-2015-06-16_(1.26wmf10).Jun 13 2015, 12:17 AM
• Forrestbot subscribed.
Restricted Application added a subscriber: Mjbmr. · View Herald TranscriptJun 13 2015, 12:17 AM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• atgo unsubscribed.Mar 30 2016, 10:03 PM
Restricted Application removed a subscriber: Mjbmr. · View Herald TranscriptMar 30 2016, 10:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL