Page MenuHomePhabricator
Create Task
Maniphest T103433

Pressing escape twice to cancel out of the link inspector, closes the entire media dialog
Closed, ResolvedPublic
Actions

Description

When typing a caption with a link, into the media dialog, if I hit [Esc] twice in order to cancel the link inspector, it closes the entire media dialog.
See screencast attached: (1.4mb - if you can't see it here, right-click "save link as" on the "view file" link at top-right of F182277).

Steps to reproduce:

  • Open media dialog.
  • insert image
  • start typing caption
  • begin to create a link, but then change your mind and try to close it with [Esc] key (once if you haven't typed anything in the link inspector, or twice if you have)
  • whole media dialog closes.

In contrast, clicking [Esc] twice within the link inspector (once you've started typing in the link inspector, or clicking once if you haven't), whilst editing an article, will just close the link inspector.

Confirmed in Firefox 38 and Chromium 37, on Ubuntu. Originally reported as a single press of the Escape key on Firefox 38 on Windows with an Icelandic keyboard.

Event Timeline

Quiddity created this task.Jun 22 2015, 10:21 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added projects: VisualEditor, VisualEditor-Links, VisualEditor-Media.
Quiddity subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2015, 10:21 PM
Quiddity updated the task description. (Show Details)Jun 22 2015, 10:22 PM
Quiddity set Security to None.
Quiddity updated the task description. (Show Details)Jun 22 2015, 10:24 PM
Quiddity updated the task description. (Show Details)Jun 22 2015, 10:34 PM
Quiddity updated the task description. (Show Details)
• Whatamidoing-WMF updated the task description. (Show Details)Jun 23 2015, 4:49 AM
Jdforrester-WMF triaged this task as Low priority.Jul 21 2015, 8:30 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Media; removed VisualEditor-Media, VisualEditor-Links.
Jdforrester-WMF subscribed.

In contrast, clicking [Esc] twice within the link inspector (once you've started typing in the link inspector, or clicking once if you haven't), whilst editing an article, will just close the link inspector.

Won't it close the editor?

Krenair subscribed.Jul 25 2015, 6:33 PM
Krenair added a project: OOUI.Jul 28 2015, 1:34 AM

Seems to be something to do with the OO.ui.Dialog code. I tried changing the onDocumentKeyDown function there to log this.constructor.name, and it prints VeUiMWMediaDialog followed by VeUiMWLinkAnnotationInspector.
Why is it backwards, and how can the second happen as first called preventDefault+stopPropagation?

Krenair added a comment.Jul 28 2015, 1:46 AM

Ah. That event is actually attached to the whole document.

Quiddity added a comment.Jul 28 2015, 3:03 AM
In T103433#1468737, @Jdforrester-WMF wrote:

In contrast, clicking [Esc] twice within the link inspector (once you've started typing in the link inspector, or clicking once if you haven't), whilst editing an article, will just close the link inspector.

Won't it close the editor?

ah, it varies depending on whether the autocomplete dropdown list is active.
If it is, then the first [Esc] will exit the autocomplete, and the second [Esc] will exit the link inspector. (e.g. if I type "test" in a link inspector at http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_%28WMF%29/Sandbox?veaction=edit ).

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Aug 4 2015, 7:24 PM
Esanders closed this task as Resolved.Apr 14 2019, 2:30 PM
Esanders claimed this task.
Esanders subscribed.

This has been fixed for a while.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 14 2019, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL