Page MenuHomePhabricator
Create Task
Maniphest T104421

Fix "PHP Fatal error: Argument 1 to setTitle() must be Title, null given" from View.php:455 in OutputPage.php:993
Closed, ResolvedPublic
Actions

Description

[Wed Jul 01 07:21:07 2015] [error] [client 90.220.15.206] [host finanpedia.nl] Backend fatal error: PHP Catchable fatal error: Argument 1 passed to OutputPage::setTitle() must be an instance of Title, null given, called in /home/*/domains/*.nl/public_html/mw/extensions/LiquidThreads/classes/View.php on line 455 and defined in /home/*/domains/*.nl/public_html/mw/includes/OutputPage.php on line 993\n, referer: http://finanpedia.nl/wiki/Overleg:Hoofdpagina

Running MediaWiki 1.25 and REL1_25 of LiquidThreads (this also happens on master)

Happens when clicking the "Add new section" tab on a blank LiquidThreads talk page as a user who doesn't have the edit right (e.g. user not yet email confirmed; $wgEmailConfirmToEdit).

Details

SubjectRepoBranchLines +/-
When user can not post a new thread, let the non-AJAX path handle itmediawiki/extensions/LiquidThreadsREL1_25+11 -8
When user can not post a new thread, let the non-AJAX path handle itmediawiki/extensions/LiquidThreadsmaster+11 -8
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jul 1 2015, 5:25 AM
Krinkle raised the priority of this task from to Unbreak Now!.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-extensions-LiquidThreads, Regression.
Krinkle subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2015, 5:25 AM
Krinkle updated the task description. (Show Details)Jul 1 2015, 5:28 AM
Krinkle set Security to None.
Krinkle updated the task description. (Show Details)Jul 1 2015, 5:33 AM
Aklapper added a comment.Jul 23 2015, 1:58 PM

Krinkle: Any idea who could/should be set as assignee? This has been "Unbreak now" for more than three weeks without activity...

Quiddity added a project: Collaboration-Team-Triage.Jul 23 2015, 6:13 PM
Quiddity subscribed.
Quiddity added a project: Collaboration-Team-Archive-2015-2016.Jul 23 2015, 8:55 PM
• DannyH removed a project: Collaboration-Team-Archive-2015-2016.Jul 24 2015, 5:12 PM
• DannyH subscribed.Jul 24 2015, 5:15 PM

I take this out of the current Collaboration sprint. As Andre noted, this was Unbreak now for three weeks. The bug is caused by a soon-to-be-deprecated feature on a wiki that I'm not familiar with, so I'm not sure why it's urgent.

Nick, is there something I'm missing about this?

• Mattflaschen-WMF subscribed.Jul 24 2015, 8:38 PM

The fact that we were not aware of this for three weeks does not imply it does not need to be fixed. It does need to be.

This is not the most important item in the sprint, but it meets the criteria for Unbreak Now and should be in the sprint.

• DannyH added a comment.Jul 24 2015, 9:06 PM

Okay, fair enough. I'll put it back in.

• DannyH added a project: Collaboration-Team-Archive-2015-2016.Jul 24 2015, 9:06 PM
• DannyH moved this task from Untriaged to Current workboard on the Collaboration-Team-Triage board.
• Mattflaschen-WMF claimed this task.Jul 25 2015, 4:07 AM
• Mattflaschen-WMF moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
• Mattflaschen-WMF updated the task description. (Show Details)Jul 28 2015, 12:18 AM
gerritbot subscribed.Jul 28 2015, 12:19 AM

Change 227376 had a related patch set uploaded (by Mattflaschen):
When user can not post a new thread, let the non-AJAX path handle it

https://gerrit.wikimedia.org/r/227376

gerritbot added a project: Patch-For-Review.Jul 28 2015, 12:19 AM
• Mattflaschen-WMF moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Jul 28 2015, 12:20 AM
• Mattflaschen-WMF added a comment.Jul 28 2015, 3:00 AM

Happens on master as well. Can be QA-ed with setting:

$wgEmailConfirmToEdit = true;

(and a user that is not email-confirmed)

Possibly also with a protected page or blocked user, but the one above is what the description mentions.

matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Jul 28 2015, 12:42 PM
gerritbot added a comment.Jul 28 2015, 12:42 PM

Change 227376 merged by jenkins-bot:
When user can not post a new thread, let the non-AJAX path handle it

https://gerrit.wikimedia.org/r/227376

• Mattflaschen-WMF mentioned this in rMEXT318cde378e0e: Updated mediawiki/extensions Project: mediawiki/extensions/LiquidThreads….Jul 28 2015, 12:42 PM
• Mattflaschen-WMF mentioned this in rELQT9194397f8ec5: When user can not post a new thread, let the non-AJAX path handle it.
• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 28 2015, 1:00 PM
Etonkovidova subscribed.Jul 30 2015, 6:11 PM

Checked on testwiki.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Jul 30 2015, 6:11 PM
gerritbot added a comment.Jul 30 2015, 9:53 PM

Change 228157 had a related patch set uploaded (by Mattflaschen):
When user can not post a new thread, let the non-AJAX path handle it

https://gerrit.wikimedia.org/r/228157

gerritbot added a comment.Jul 31 2015, 6:14 AM

Change 228157 merged by jenkins-bot:
When user can not post a new thread, let the non-AJAX path handle it

https://gerrit.wikimedia.org/r/228157

• Mattflaschen-WMF mentioned this in rELQT36857ffabd24: When user can not post a new thread, let the non-AJAX path handle it.Jul 31 2015, 6:14 AM
• DannyH closed this task as Resolved.Jul 31 2015, 5:34 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Archive-2015-2016 board.
• DannyH moved this task from Current workboard to Resolved on the Collaboration-Team-Triage board.Jul 31 2015, 5:47 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 2 2018, 10:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL