Invalid argument supplied for foreach() in LoadBalancer.php
Closed, ResolvedPublic
Actions

Description

Spotted in production:

13 Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.26wmf12/includes/db/LoadBalancer.php on line 1221

Details

Subject	Repo	Branch	Lines +/-
This should fix T105373	mediawiki/core	master	+1 -1
Hotfix for T105373	mediawiki/core	wmf/1.26wmf14	+1 -1
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name	mediawiki/core	master	+1 -1

Customize query in gerrit

Revisions and Commits

rMW MediaWiki
	rMW7f9e12ee18e3 Merge "This should fix T105373"
	rMWeb74225bb839 This should fix T105373

Related Objects

Mentioned In: rMWe64db8e6ece4: Hotfix for T105373
rMWe8552b7e5e3f: Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name
Mentioned Here: rMW9cf6637a751d: Use APC for caching slave lag times

Event Timeline

• demon created this task.Jul 9 2015, 5:34 PM

• demon raised the priority of this task from to Medium.

• demon updated the task description. (Show Details)

• demon added projects: Wikimedia-production-error, MediaWiki-libs-Rdbms.

• demon moved this task to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

• demon subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2015, 5:34 PM

Actually, this is happening thousands of times in the logs. Raising priority.

Last change in that area is https://gerrit.wikimedia.org/r/#/c/216857/
But I cannot test if that is the problem.

In T105373#1442332, @Umherirrender wrote:

Last change in that area is https://gerrit.wikimedia.org/r/#/c/216857/
But I cannot test if that is the problem.

Could be dueling cache keys with mixed MW versions, as the name is the same and they both have 'timestamp'.

Change 223955 had a related patch set uploaded (by Aaron Schulz):
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name

https://gerrit.wikimedia.org/r/223955

gerritbot added a project: Patch-For-Review.Jul 9 2015, 8:31 PM

Change 223955 merged by jenkins-bot:
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name

https://gerrit.wikimedia.org/r/223955

aaron mentioned this in rMWe8552b7e5e3f: Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name.Jul 9 2015, 9:53 PM

• Forrestbot added projects: WMF-deploy-2015-07-14_(1.26wmf14), MW-1.26-release.Jul 9 2015, 10:00 PM

• demon moved this task from Dec2019/1.35.wmf.10+ to Jan 2019 / 1.33.wmf13–14 on the Wikimedia-production-error board.Jul 10 2015, 3:00 PM

• demon moved this task from Jan 2019 / 1.33.wmf13–14 to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Jul 10 2015, 3:11 PM

• demon moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Jul 15 2015, 2:47 AM

• demon moved this task from Resolved to Jan 2019 / 1.33.wmf13–14 on the Wikimedia-production-error board.Jul 16 2015, 6:43 PM

• demon merged a task: T106072: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.26wmf13/includes/db/LoadBalancer.php (line 176 and line 1221).

• demon added a subscriber: • mmodell.

see my audit of rMW9cf6637a751d018bc2bec26ea0f1a9de936c2c9c

Change 225123 had a related patch set uploaded (by 20after4):
Hotfix for T105373

https://gerrit.wikimedia.org/r/225123

Change 225124 had a related patch set uploaded (by 20after4):
This should fix T105373

https://gerrit.wikimedia.org/r/225124

Change 225123 merged by jenkins-bot:
Hotfix for T105373

https://gerrit.wikimedia.org/r/225123

aaron mentioned this in rMWe64db8e6ece4: Hotfix for T105373.Jul 16 2015, 7:14 PM

Change 225124 merged by jenkins-bot:
This should fix T105373

https://gerrit.wikimedia.org/r/225124

• mmodell closed this task as Resolved by committing rMWeb74225bb839: This should fix T105373.Jul 16 2015, 9:55 PM

• mmodell added a commit: rMWeb74225bb839: This should fix T105373.

Diffusion added a commit: rMW7f9e12ee18e3: Merge "This should fix T105373".Jul 16 2015, 9:55 PM

• Forrestbot added a project: WMF-deploy-2015-07-21_(1.26wmf15).Jul 16 2015, 10:00 PM

• demon moved this task from Jan 2019 / 1.33.wmf13–14 to Resolved on the Wikimedia-production-error board.Jul 17 2015, 12:15 AM

Invalid argument supplied for foreach() in LoadBalancer.phpClosed, ResolvedPublicActions