Page MenuHomePhabricator

Invalid argument supplied for foreach() in LoadBalancer.php
Closed, ResolvedPublic

Description

Spotted in production:

13 Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.26wmf12/includes/db/LoadBalancer.php on line 1221

Revisions and Commits

Event Timeline

demon raised the priority of this task from to Medium.
demon updated the task description. (Show Details)
demon moved this task to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
demon added a subscriber: demon.
demon raised the priority of this task from Medium to Unbreak Now!.Jul 9 2015, 5:35 PM

Actually, this is happening thousands of times in the logs. Raising priority.

Last change in that area is https://gerrit.wikimedia.org/r/#/c/216857/
But I cannot test if that is the problem.

Last change in that area is https://gerrit.wikimedia.org/r/#/c/216857/
But I cannot test if that is the problem.

Could be dueling cache keys with mixed MW versions, as the name is the same and they both have 'timestamp'.

Change 223955 had a related patch set uploaded (by Aaron Schulz):
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name

https://gerrit.wikimedia.org/r/223955

Change 223955 merged by jenkins-bot:
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name

https://gerrit.wikimedia.org/r/223955

Change 225123 had a related patch set uploaded (by 20after4):
Hotfix for T105373

https://gerrit.wikimedia.org/r/225123

Change 225124 had a related patch set uploaded (by 20after4):
This should fix T105373

https://gerrit.wikimedia.org/r/225124