Page MenuHomePhabricator

Invalid argument supplied for foreach() in LoadBalancer.php
Closed, ResolvedPublic

Description

Spotted in production:

13 Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.26wmf12/includes/db/LoadBalancer.php on line 1221

Event Timeline

demon created this task.Jul 9 2015, 5:34 PM
demon raised the priority of this task from to Normal.
demon updated the task description. (Show Details)
demon added a subscriber: demon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2015, 5:34 PM
demon raised the priority of this task from Normal to Unbreak Now!.Jul 9 2015, 5:35 PM

Actually, this is happening thousands of times in the logs. Raising priority.

Last change in that area is https://gerrit.wikimedia.org/r/#/c/216857/
But I cannot test if that is the problem.

aaron added a comment.Jul 9 2015, 8:24 PM

Last change in that area is https://gerrit.wikimedia.org/r/#/c/216857/
But I cannot test if that is the problem.

Could be dueling cache keys with mixed MW versions, as the name is the same and they both have 'timestamp'.

Change 223955 had a related patch set uploaded (by Aaron Schulz):
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name

https://gerrit.wikimedia.org/r/223955

Change 223955 merged by jenkins-bot:
Made LoadMonitor use wfGlobalCacheKey() and tweaked the key name

https://gerrit.wikimedia.org/r/223955

Change 225123 had a related patch set uploaded (by 20after4):
Hotfix for T105373

https://gerrit.wikimedia.org/r/225123

Change 225124 had a related patch set uploaded (by 20after4):
This should fix T105373

https://gerrit.wikimedia.org/r/225124

Change 225123 merged by jenkins-bot:
Hotfix for T105373

https://gerrit.wikimedia.org/r/225123

Change 225124 merged by jenkins-bot:
This should fix T105373

https://gerrit.wikimedia.org/r/225124