Page MenuHomePhabricator

Link editor can't be closed
Closed, ResolvedPublic1 Story Points

Description

Reported at https://fi.wikipedia.org/wiki/Wikipedia:Visuaalinen_muokkain/Palaute
User told that they can't add links at all using VE. When they click "done" the link editor is just loading. Even if they click cancel nothing happens, so it gets stuck.

I tried to reproduce and I succeed to add links, but when I chose text containing a empty line I can reproduce the error. In the console I can see "TypeError: newSel.equalsSelection is not a function".

Event Timeline

Stryn created this task.Jul 19 2015, 1:47 PM
Stryn raised the priority of this task from to Needs Triage.
Stryn updated the task description. (Show Details)
Stryn added a project: VisualEditor.
Stryn added a subscriber: Stryn.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 1:47 PM
Jdforrester-WMF triaged this task as High priority.Jul 21 2015, 7:08 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set Security to None.

Change 226158 had a related patch set uploaded (by Catrope):
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226158

Change 226178 had a related patch set uploaded (by Jforrester):
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226178

Change 226189 had a related patch set uploaded (by Jforrester):
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226189

Change 226189 merged by jenkins-bot:
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226189

Change 226178 merged by jenkins-bot:
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226178

Change 226158 merged by jenkins-bot:
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226158

Change 226217 had a related patch set uploaded (by Jforrester):
Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0)

https://gerrit.wikimedia.org/r/226217

Change 226218 had a related patch set uploaded (by Jforrester):
Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b)

https://gerrit.wikimedia.org/r/226218

Change 226217 merged by jenkins-bot:
Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0)

https://gerrit.wikimedia.org/r/226217

Change 226218 merged by jenkins-bot:
Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b)

https://gerrit.wikimedia.org/r/226218

Should now be fixed everywhere.