Page MenuHomePhabricator
Create Task
Maniphest T106270

Link editor can't be closed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reported at https://fi.wikipedia.org/wiki/Wikipedia:Visuaalinen_muokkain/Palaute
User told that they can't add links at all using VE. When they click "done" the link editor is just loading. Even if they click cancel nothing happens, so it gets stuck.

I tried to reproduce and I succeed to add links, but when I chose text containing a empty line I can reproduce the error. In the console I can see "TypeError: newSel.equalsSelection is not a function".

Details

SubjectRepoBranchLines +/-
Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b)mediawiki/extensions/VisualEditorwmf/1.26wmf15+1 -1
Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0)mediawiki/extensions/VisualEditorwmf/1.26wmf14+1 -1
Make ve.SelectionState#flip return an actual SelectionStateVisualEditor/VisualEditormaster+3 -3
Make ve.SelectionState#flip return an actual SelectionStateVisualEditor/VisualEditorwmf/1.26wmf15+3 -3
Make ve.SelectionState#flip return an actual SelectionStateVisualEditor/VisualEditorwmf/1.26wmf14+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Stryn created this task.Jul 19 2015, 1:47 PM
Stryn raised the priority of this task from to Needs Triage.
Stryn updated the task description. (Show Details)
Stryn added a project: VisualEditor.
Stryn subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 1:47 PM
Trizek-WMF subscribed.Jul 19 2015, 3:04 PM
Jdforrester-WMF triaged this task as High priority.Jul 21 2015, 7:08 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.
Jdforrester-WMF set Security to None.
Catrope merged a task: T106402: Weird behavior of Link Editor in Flow's VE post editor.Jul 21 2015, 7:40 PM
Catrope added a subscriber: • Spage.
gerritbot subscribed.Jul 21 2015, 7:44 PM

Change 226158 had a related patch set uploaded (by Catrope):
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226158

gerritbot added a project: Patch-For-Review.Jul 21 2015, 7:44 PM
gerritbot added a comment.Jul 21 2015, 7:46 PM

Change 226178 had a related patch set uploaded (by Jforrester):
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226178

Jdforrester-WMF closed this task as Resolved.Jul 21 2015, 7:47 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF edited projects, added WMF-deploy-2015-07-28_(1.26wmf16), WMF-deploy-2015-07-21_(1.26wmf15); removed Patch-For-Review.
gerritbot added a comment.Jul 21 2015, 7:47 PM

Change 226189 had a related patch set uploaded (by Jforrester):
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226189

gerritbot added a project: Patch-For-Review.Jul 21 2015, 7:47 PM
Jdforrester-WMF added a project: WMF-deploy-2015-07-14_(1.26wmf14).Jul 21 2015, 7:48 PM
gerritbot added a comment.Jul 21 2015, 8:08 PM

Change 226189 merged by jenkins-bot:
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226189

gerritbot added a comment.Jul 21 2015, 8:08 PM

Change 226178 merged by jenkins-bot:
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226178

gerritbot added a comment.Jul 21 2015, 8:08 PM

Change 226158 merged by jenkins-bot:
Make ve.SelectionState#flip return an actual SelectionState

https://gerrit.wikimedia.org/r/226158

Catrope mentioned this in rGVEDaeaad4e0e7b1: Make ve.SelectionState#flip return an actual SelectionState.Jul 21 2015, 8:09 PM
Jdforrester-WMF mentioned this in rGVED50893b058507: Make ve.SelectionState#flip return an actual SelectionState.Jul 21 2015, 8:09 PM
Jdforrester-WMF mentioned this in rGVED2cbe96b4b0ec: Make ve.SelectionState#flip return an actual SelectionState.
gerritbot added a comment.Jul 21 2015, 8:15 PM

Change 226217 had a related patch set uploaded (by Jforrester):
Update VE core submodule to wmf/1.26wmf14 HEAD (rGVED50893b058507)

https://gerrit.wikimedia.org/r/226217

gerritbot added a comment.Jul 21 2015, 8:16 PM

Change 226218 had a related patch set uploaded (by Jforrester):
Update VE core submodule to wmf/1.26wmf15 HEAD (rGVED2cbe96b4b0ec)

https://gerrit.wikimedia.org/r/226218

gerritbot added a comment.Jul 21 2015, 11:05 PM

Change 226217 merged by jenkins-bot:
Update VE core submodule to wmf/1.26wmf14 HEAD (rGVED50893b058507)

https://gerrit.wikimedia.org/r/226217

gerritbot added a comment.Jul 21 2015, 11:05 PM

Change 226218 merged by jenkins-bot:
Update VE core submodule to wmf/1.26wmf15 HEAD (rGVED2cbe96b4b0ec)

https://gerrit.wikimedia.org/r/226218

Jdforrester-WMF mentioned this in rEVED16d7165176cf: Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b).Jul 21 2015, 11:05 PM
Jdforrester-WMF mentioned this in rEVED07deebbe99e2: Update VE core submodule to wmf/1.26wmf14 HEAD (50893b0).
Jdforrester-WMF removed a project: Patch-For-Review.Jul 21 2015, 11:09 PM
Jdforrester-WMF subscribed.Jul 21 2015, 11:36 PM

Should now be fixed everywhere.

Jdforrester-WMF edited a custom field.Jul 21 2015, 11:37 PM
Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Jul 29 2015, 4:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL