Page MenuHomePhabricator
Create Task
Maniphest T106347

Safari regression: Edit button for H2 left aligned
Closed, ResolvedPublic
Actions

Description

English Wikipedia,
Logged in and logged out
Beta and Experimental mode disabled.
Safari 9 (10601.1.35.2.4), Mac OS X 10.10.4

Screen Shot 2015-07-20 at 21.55.29.png (208×365 px, 20 KB)

According to the CSS2 spec [1] missing elements in the table model
should be assumed in order for the table model to work. Safari does not
seem to generate anonymous table objects for the missing elements.
(needs reference). We should update this phabricator task if we find an upstream Safari bug. Note the bug is also in Safari 7.

[1] http://www.w3.org/TR/CSS2/tables.html#anonymous-boxes

Details

SubjectRepoBranchLines +/-
Fix the position of the edit button in Safarimediawiki/extensions/MobileFrontendmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Jul 20 2015, 7:56 PM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: Mobile, Web-Team-Backlog.
TheDJ subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2015, 7:56 PM
TheDJ updated the task description. (Show Details)Jul 20 2015, 7:57 PM
TheDJ set Security to None.
Jdlrobson subscribed.Jul 20 2015, 11:24 PM

Fine in Firefox, IE and Chrome - just Safari. (grumbles about how Safari is the new IE)

Jdlrobson renamed this task from Edit button for H2 has become left aligned on Mobile to Safari regression: Edit button for H2 left aligned.Jul 20 2015, 11:25 PM
Jdlrobson added projects: MobileFrontend, Reading-Web-Sprint-52-Zoolander.
Jdlrobson moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Jul 21 2015, 12:33 AM
TheDJ added a project: Browser-Support-Apple-Safari.Jul 21 2015, 9:24 AM
Jdlrobson claimed this task.Jul 21 2015, 8:05 PM
Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson added a comment.Jul 21 2015, 8:43 PM

Looks like some kind of issue with display:table-cell inside an element that is not display: table-row

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 21 2015, 8:50 PM
Jdlrobson moved this task from Doing to To Do on the Reading-Web-Sprint-52-Zoolander board.
• bmansurov claimed this task.Jul 22 2015, 8:13 PM
• bmansurov moved this task from To Do to Code Review on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson moved this task from Code Review to Doing on the Reading-Web-Sprint-52-Zoolander board.Jul 22 2015, 11:22 PM
gerritbot subscribed.Jul 22 2015, 11:51 PM

Change 226450 had a related patch set uploaded (by Bmansurov):
Fix the position of the edit button in Safari

https://gerrit.wikimedia.org/r/226450

gerritbot added a project: Patch-For-Review.Jul 22 2015, 11:51 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-52-Zoolander board.Jul 22 2015, 11:51 PM
Jdlrobson updated the task description. (Show Details)Jul 24 2015, 7:57 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-52-Zoolander board.
gerritbot added a comment.Jul 24 2015, 8:06 PM

Change 226450 merged by jenkins-bot:
Fix the position of the edit button in Safari

https://gerrit.wikimedia.org/r/226450

• bmansurov mentioned this in rEMFRf8e2d2564043: Fix the position of the edit button in Safari.Jul 24 2015, 8:06 PM
Diffusion mentioned this in rMEXTb1790c5a37a4: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 24 2015, 8:06 PM
• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 24 2015, 9:00 PM
• Jhernandez closed this task as Resolved.Jul 29 2015, 10:48 AM
• Jhernandez subscribed.

Seems to work fine, tested iOS and mac's safari on http://test.m.wikipedia.org/wiki/Headings

• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-52-Zoolander board.Jul 29 2015, 10:48 AM
• Phabricator_maintenance moved this task from 2016-17 Q2 to 2015-16 Q1 on the Web-Team-Backlog board.Mar 7 2018, 1:14 AM
Izno mentioned this in T300695: Remove the SubHeadingTransform (Don't apply in-block to headings).Feb 2 2022, 2:48 AM
matmarex mentioned this in T305971: Change styling for Minerva/MobileFrontend section headings to use flexbox instead of table-cells.Apr 12 2022, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits