Thumbnails no longer rendering for recent local uploads
Closed, ResolvedPublic

AdamCuerden updated the task description. (Show Details)
AdamCuerden raised the priority of this task from to Needs Triage.
AdamCuerden added a subscriber: AdamCuerden.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2015, 9:23 PM
GOIII renamed this task from Thumbnail issues to Thumbnails no longer rendering for recent local uploads.Jul 24 2015, 11:02 PM
GOIII updated the task description. (Show Details)
GOIII set Security to None.
Restricted Application added a project: Multimedia. · View Herald TranscriptJul 24 2015, 11:11 PM

It is not only enwiki problem, I guess. Here is a link to Latvian Wikipedia file.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 25 2015, 9:09 AM
Peachey88 triaged this task as Unbreak Now! priority.Jul 25 2015, 9:19 AM
Restricted Application added a subscriber: Steinsplitter. · View Herald TranscriptJul 25 2015, 9:19 AM

Seems to be fixed. Thanks!

faidon closed this task as Resolved.Jul 25 2015, 10:33 AM
faidon claimed this task.
faidon added a subscriber: faidon.

Aaron's guess was correct. Both 9d45102200e7196ba4933103a3fa1144509515a9 and 3bfb0b5d4e874ba66fb857b36feac173918fc458 were reverted with d773c225abdec5256bc70506565d7d364212c00c, which seems to have alleviated the problems for now.

Also see bugs T84842, T106743.

Joe added a subscriber: Joe.Jul 25 2015, 6:02 PM

A bit of post-mortem:

while 9d45102200e7196ba4933103a3fa1144509515a9 was correct, 3bfb0b5d4e874ba66fb857b36feac173918fc458 wasn't, as the proxypass was made to a path that was not within the DOCROOT of apache.

As a consequence, mod_proxy_fcgi was sending to HHVM:

SCRIPT_FILENAME=proxy:fcgi://127.0.0.1:9000/srv/mediawiki/docroot/wikimedia.org/thumb_handler.php...
CONTEXT_DOCUMENT_ROOT=/srv/mediawiki/wikipedia.org

when HHVM tries to mimick what ZEND does, it strips the DOCROOT from the SCRIPT_NAME it creates, but in this case the DOCROOT is different than the path it gets from SCRIPT_FILENAME, so the result is

SCRIPT_NAME="/srv/mediawiki/docroot/wikimedia.org/w/thumb_handler.php"

instead of

SCRIPT_NAME="/w/thumb_handler.php"

which is what the code expects (it's the value of $_SERVER['SCRIPT_NAME'] under Zend.