Page MenuHomePhabricator
Create Task
Maniphest T107322

Trim the user's search string from Google Books search URLs
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

There's a minor potential privacy leak (Google can spot their users being our editors) arising from the search string of pasted into Citoid; would be nice to trim the user's search string ("q=…") to avoid this.

Details

SubjectRepoBranchLines +/-
Add url field to Google Books citationmediawiki/services/zotero/translatorsmaster+24 -19
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jul 29 2015, 5:35 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: Citoid, VisualEditor, Privacy.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2015, 5:35 PM
Krinkle subscribed.Jul 29 2015, 6:51 PM

In general using the canonical url (either link rel=canonical or meta name=og:url) would be a good idea for citations. That would automatically solve this.

CFCF subscribed.Jul 29 2015, 11:39 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 30 2015, 5:35 PM
Jdforrester-WMF set Security to None.Jul 31 2015, 11:20 PM
Jdforrester-WMF edited a custom field.
Mvolz moved this task from Backlog to Site specific issues on the Citoid board.Aug 1 2015, 7:34 AM
gerritbot subscribed.Aug 1 2015, 11:13 AM

Change 228467 had a related patch set uploaded (by Mvolz):
Add url field to citation

https://gerrit.wikimedia.org/r/228467

gerritbot added a project: Patch-For-Review.Aug 1 2015, 11:13 AM
gerritbot added a comment.Aug 12 2015, 6:49 PM

Change 228467 merged by Mobrovac:
Add url field to Google Books citation

https://gerrit.wikimedia.org/r/228467

Mvolz mentioned this in rGZTTbcc21478c63b: Add url field to Google Books citation.Aug 12 2015, 9:20 PM
• mobrovac closed this task as Resolved.Aug 20 2015, 11:40 AM
• mobrovac claimed this task.
• mobrovac moved this task from Site specific issues to Waiting on Deploy on the Citoid board.
• mobrovac subscribed.

Deployed, resolving.

• mobrovac removed a project: Patch-For-Review.Aug 20 2015, 11:40 AM
• mobrovac removed a subscriber: gerritbot.
Mvolz mentioned this in T113262: Keep page number parameter when processing Google Books links.Sep 30 2015, 6:09 PM
sbassett moved this task from Intake to Done on the Privacy board.Oct 16 2019, 5:49 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 16 2019, 5:49 PM
Mvolz mentioned this in T212608: Keep anchor when generating reference from URL.Dec 10 2019, 10:21 AM
Mvolz mentioned this in T242089: Consider keeping user entered URL and removing tracking parameters .Jan 7 2020, 10:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits