Page MenuHomePhabricator

Various mobile module dependencies on stale cached pages in production for some non logged in users
Closed, ResolvedPublic

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_page_issues_test_page in an incognito window

It appears that JS is not enabled, but in fact it seems mobiles modules are not getting loaded.

mw.loader.getState( 'mobile.issues' )

registered

mw.loader.getState( 'mobile.startup' )

registered

mw.loader.getState( 'skins.minerva.scripts' )

registered

Note mobile.startup is a dependency of skins.minerva.scripts and skins.minerva.scripts

Looking at bottom of document in view source I see
mw.loader.load(["mediawiki.page.startup","mobile.head","mobile.site","ext.centralNotice.bannerController.mobiledevice","ext.centralNotice.bannerController.mobile","ext.centralNotice.bannerController.lib","ext.centralNotice.bannerChoiceData","ext.centralauth.centralautologin","ext.imageMetrics.head"]);
which includes skins.minerva.scripts ... why did it not load?

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Jdlrobson, Krinkle, ori.

^ @ori @Krinkle I suspect related to your recent changes? Any ideas?

Purging cache seemed to fix http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_page_issues_test_page
Are we intentionally serving non-JS site to cached pages?

Okay so I talked to @Krinkle in irc [1] and to summarise, the performance team is rolling out these changes in such a way that cached html will not be a problem. I have flushed caches for problematic pages on beta labs and started a new job [2] to check our tests are passing again. If it passes I think we are good to go.

[1] P1836
[2] https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/776/

Jdlrobson renamed this task from Various mobile module dependencies not loading on beta labs for non logged in users to Various mobile module dependencies on stale cached pages in production for some non logged in users.Aug 10 2015, 6:12 PM
Jdlrobson reopened this task as Open.
Jdlrobson triaged this task as Unbreak Now! priority.
Jdlrobson moved this task from Done to To Do on the Reading-Web-Sprint-53-12-Monkeys board.

This is now on production, so apparently cached HTML is a problem. Not sure how best to fix it though.

I'm still puzzled why this bug wouldn't impact desktop as well as mobile. The inline `if ( mw.mobileFrontend checks only impact non-essential functionality and are covered in T108204

@ori has suggested doing a cache flush for mobile @BBlack has done one recently which wasn't too costly.

I am however concerned at how desktop doesn't have this issue... are we sure that it doesn't?

Okay so there was a bit of a misunderstanding and according to @Krinkle it is expected that there are some pages that will still load from cache and thus non run JS. This is also likely to be the case for a small amount of pages in desktop.

Content over 3 weeks old (a small % of pages) will just be like this until their cache purges so potentially nothing to do here. We can flush it if we really want to...

@Jdlrobson What do you think. Should we flush cache? What is a small % of pages?

Nothing happened to my knowledge. I personally didn't think it was worth the hassle. Cached pages should be less of a problem right now.

Ok, closing then. We'll reopen is this comes back or it becomes something serious.

It looks like I happened to hit this. I'm unsure if it's common, but see the picture for an example. The particularly affected page seems to be working fine now.