Various mobile module dependencies on stale cached pages in production for some non logged in users
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 5 2015, 4:18 PM

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_page_issues_test_page in an incognito window

It appears that JS is not enabled, but in fact it seems mobiles modules are not getting loaded.

mw.loader.getState( 'mobile.issues' )

registered

mw.loader.getState( 'mobile.startup' )

registered

mw.loader.getState( 'skins.minerva.scripts' )

registered

Note mobile.startup is a dependency of skins.minerva.scripts and skins.minerva.scripts

Looking at bottom of document in view source I see
mw.loader.load(["mediawiki.page.startup","mobile.head","mobile.site","ext.centralNotice.bannerController.mobiledevice","ext.centralNotice.bannerController.mobile","ext.centralNotice.bannerController.lib","ext.centralNotice.bannerChoiceData","ext.centralauth.centralautologin","ext.imageMetrics.head"]);
which includes skins.minerva.scripts ... why did it not load?

Related Objects

Mentioned Here: T108204: Regression: Last modified bar code not running in async mode
P1836 Conversation about async RL changes

Event Timeline

Jdlrobson created this task.Aug 5 2015, 4:18 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Reading-Web-Sprint-53-12-Monkeys.

Jdlrobson moved this task to Needs Analysis on the Reading-Web-Sprint-53-12-Monkeys board.

Jdlrobson added subscribers: Jdlrobson, Krinkle, ori.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 4:18 PM

^ @ori @Krinkle I suspect related to your recent changes? Any ideas?

Purging cache seemed to fix http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_page_issues_test_page
Are we intentionally serving non-JS site to cached pages?

http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_References_test_page still has same problem
Here's the cached html - https://phabricator.wikimedia.org/P1835

Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 5:52 PM

Jdlrobson added a project: Performance-Team.Aug 5 2015, 5:57 PM

Jdlrobson set Security to None.

Okay so I talked to @Krinkle in irc [1] and to summarise, the performance team is rolling out these changes in such a way that cached html will not be a problem. I have flushed caches for problematic pages on beta labs and started a new job [2] to check our tests are passing again. If it passes I think we are good to go.

[1] P1836
[2] https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/776/

Jdlrobson moved this task from Doing to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 6:13 PM

Great, thanks @Jdlrobson.

• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 12:34 PM

This is now on production, so apparently cached HTML is a problem. Not sure how best to fix it though.

I'm still puzzled why this bug wouldn't impact desktop as well as mobile. The inline `if ( mw.mobileFrontend checks only impact non-essential functionality and are covered in T108204

@ori has suggested doing a cache flush for mobile @BBlack has done one recently which wasn't too costly.

I am however concerned at how desktop doesn't have this issue... are we sure that it doesn't?

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 8:05 PM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 8:23 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.

Okay so there was a bit of a misunderstanding and according to @Krinkle it is expected that there are some pages that will still load from cache and thus non run JS. This is also likely to be the case for a small amount of pages in desktop.

Content over 3 weeks old (a small % of pages) will just be like this until their cache purges so potentially nothing to do here. We can flush it if we really want to...

Jdlrobson moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 8:26 PM

Krinkle unsubscribed.Aug 11 2015, 2:03 AM

@Jdlrobson What do you think. Should we flush cache? What is a small % of pages?

Ping @Jdlrobson? What's happened with this?

Nothing happened to my knowledge. I personally didn't think it was worth the hassle. Cached pages should be less of a problem right now.

Ok, closing then. We'll reopen is this comes back or it becomes something serious.

• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.Aug 17 2015, 9:13 AM

It looks like I happened to hit this. I'm unsure if it's common, but see the picture for an example. The particularly affected page seems to be working fine now.

	F2467202: IMG_0919.jpg
	Aug 27 2015, 9:18 PM

Various mobile module dependencies on stale cached pages in production for some non logged in usersClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Various mobile module dependencies on stale cached pages in production for some non logged in users
Closed, ResolvedPublic
Actions