Page MenuHomePhabricator
Create Task
Maniphest T108124

[Regression] ResourceLoader no longer ensures presence of mw.util and wikibits before site/user modules
Closed, ResolvedPublic
Actions

Description

The configurables $wgIncludeLegacyJavaScript and $wgPreloadJavaScriptMwUtil add modules mediawiki.legacy.wikibits and mediawiki.util respectively to the top queue with the intention that they are guaranteed to load before the site and user modules.

Now that the top queue javascript is asynchronous (T107399) this dependency needs to be made explicit instead of implicit.

Details

SubjectRepoBranchLines +/-
resourceloader: Restore "blocking" legacy modulesmediawiki/coremaster+59 -44
resourceloader: Restore "blocking" legacy modulesmediawiki/corewmf/1.26wmf17+59 -44
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Aug 5 2015, 9:51 PM
Krinkle claimed this task.
Krinkle raised the priority of this task from to Unbreak Now!.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-ResourceLoader, Regression.
Krinkle added subscribers: Krinkle, ori, Jdforrester-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 9:51 PM
Krinkle updated the task description. (Show Details)Aug 5 2015, 9:52 PM
Krinkle set Security to None.
gerritbot subscribed.Aug 5 2015, 10:42 PM

Change 229594 had a related patch set uploaded (by Krinkle):
resourceloader: Restore "blocking" legacy modules

https://gerrit.wikimedia.org/r/229594

gerritbot added a project: Patch-For-Review.Aug 5 2015, 10:42 PM
gerritbot added a comment.Aug 6 2015, 2:59 AM

Change 229594 merged by jenkins-bot:
resourceloader: Restore "blocking" legacy modules

https://gerrit.wikimedia.org/r/229594

ori mentioned this in rMW0ac4f99804c4: resourceloader: Restore "blocking" legacy modules.Aug 6 2015, 2:59 AM
• Forrestbot added projects: WMF-deploy-2015-08-11_(1.26wmf18), MW-1.26-release.Aug 6 2015, 3:00 AM
• MZMcBride subscribed.Aug 6 2015, 3:02 AM
gerritbot added a comment.Aug 6 2015, 3:34 AM

Change 229621 had a related patch set uploaded (by Krinkle):
resourceloader: Restore "blocking" legacy modules

https://gerrit.wikimedia.org/r/229621

gerritbot added a comment.Aug 6 2015, 3:44 AM

Change 229621 merged by jenkins-bot:
resourceloader: Restore "blocking" legacy modules

https://gerrit.wikimedia.org/r/229621

Krinkle mentioned this in rMWd6d4fa1bb702: resourceloader: Restore "blocking" legacy modules.Aug 6 2015, 3:44 AM
• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Aug 6 2015, 4:00 AM
Krinkle closed this task as Resolved.Aug 6 2015, 4:03 AM
Jdlrobson mentioned this in T108191: Mobile site not functional - Uncaught Error: Unknown dependency: mediawiki.legacy.wikibits.Aug 6 2015, 3:25 PM
greg added a parent task: T108197: Blockers for 1.26wmf18 (released on 2015-08-11).Aug 6 2015, 4:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL