Page MenuHomePhabricator
Create Task
Maniphest T109599

When inserting an image on a sub-page (Foo/Bar), the target of links in captions link to sibling pages (Foo/Baz) rather than uncle pages (Baz)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This only "works" (breaks) on newly inserted images.

  1. "Insert" > "Media".
  2. Choose a file and "Use this image".
  3. Write a caption.
  4. Add a wikilink to the caption ("[[example]]").
  5. Before clicking "Insert" for the image, select the newly created link. Open the link (e.g., right-click the link in the context menu) and open it in a new tab.

Result:

If you start in a /subpage, then the link goes to https://en.wikipedia.org/wiki/User:Whatamidoing_(WMF)/example (case sensitive). Another editor reported a link of en.wikipedia.org/w/linkname instead of en.wikipedia.org/wiki/linkname. See original report.

Details

SubjectRepoBranchLines +/-
ve.dm.MWReferenceModel: Require parent documentmediawiki/extensions/VisualEditormaster+9 -51
ve.dm.MWImageModel: Require parent documentmediawiki/extensions/VisualEditormaster+36 -78
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Aug 19 2015, 5:24 PM
• Whatamidoing-WMF raised the priority of this task from to Medium.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added a project: VisualEditor-MediaWiki-Media.
• Whatamidoing-WMF subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 19 2015, 5:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
99of9 subscribed.Aug 20 2015, 7:50 AM
Jdforrester-WMF renamed this task from Links in captions for new images don't link to the correct page in the media dialog to When inserting an image on a sub-page (Foo/Bar), the target of links in captions link to sibling pages (Foo/Baz) rather than uncle pages (Baz).Aug 21 2015, 8:15 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF subscribed.

We fixed this a year ago or so for the main document. Did we forget to do it for images? What about references?

Jdforrester-WMF edited a custom field.Aug 21 2015, 8:15 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
• Catrope claimed this task.Aug 27 2015, 6:38 AM
gerritbot subscribed.Aug 27 2015, 6:53 AM

Change 234215 had a related patch set uploaded (by Catrope):
ve.dm.MWImageModel: Require parent document

https://gerrit.wikimedia.org/r/234215

gerritbot added a project: Patch-For-Review.Aug 27 2015, 6:53 AM

Change 234216 had a related patch set uploaded (by Catrope):
ve.dm.MWReferenceModel: Require parent document

https://gerrit.wikimedia.org/r/234216

• Catrope added a comment.Aug 27 2015, 7:01 AM
In T109599#1561772, @Jdforrester-WMF wrote:

We fixed this a year ago or so for the main document. Did we forget to do it for images?

Kind of. It was broken for new images, but it worked for existing images. It even went so far that you could create an image (and see the broken behavior while writing the caption), but if you inserted it and then immediately inspected it, you would see correct behavior: inspecting even a freshly inserted image is enough to send you down the "existing image" code path and avoid the "new image" code path, and only the latter was affected by this bug.

What about references?

Good thinking. ImageModel and ReferenceModel had almost identical bugs, and the user-facing behavior was completely identical (broken for new ones, works for existing ones, even if you created them 3 seconds ago). I wouldn't have noticed that if you hadn't brought it up. You actually primed me into investigating and fixing the reference case first, which then turned out to be almost the same but slightly simpler than the image case.

Krenair subscribed.Aug 27 2015, 3:33 PM
gerritbot added a comment.Aug 27 2015, 3:34 PM

Change 234215 merged by jenkins-bot:
ve.dm.MWImageModel: Require parent document

https://gerrit.wikimedia.org/r/234215

• Catrope mentioned this in rEVEDe4d2d4785e30: ve.dm.MWImageModel: Require parent document.Aug 27 2015, 3:35 PM
gerritbot added a comment.Aug 27 2015, 3:38 PM

Change 234216 merged by jenkins-bot:
ve.dm.MWReferenceModel: Require parent document

https://gerrit.wikimedia.org/r/234216

Jdforrester-WMF closed this task as Resolved.Aug 27 2015, 3:38 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-09-01_(1.26wmf21); removed Patch-For-Review.
• Catrope mentioned this in rEVEDf11fbee27823: ve.dm.MWReferenceModel: Require parent document.Aug 27 2015, 3:38 PM
• Whatamidoing-WMF mentioned this in T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.Sep 1 2015, 11:55 PM
Ryasmeen added a project: Verified-in-Phase0.Sep 2 2015, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits