Page MenuHomePhabricator
Create Task
Maniphest T109646

Remove "Open" button from all four link inspectors
Closed, ResolvedPublic8 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Revert "MWLinkNodeInspector: Remove 'Open' button"mediawiki/extensions/VisualEditormaster+29 -0
Remove the "Open" button from link inspectorsVisualEditor/VisualEditormaster+1 -22
MWLinkNodeInspector: Remove 'Open' buttonmediawiki/extensions/VisualEditormaster+0 -29
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Aug 19 2015, 10:18 PM
Jdforrester-WMF raised the priority of this task from to Low.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki-Links, good first task.
Jdforrester-WMF moved this task to Needs Discussion/Analysis on the VisualEditor board.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 10:18 PM
gerritbot subscribed.Aug 19 2015, 10:59 PM

Change 232653 had a related patch set uploaded (by Jforrester):
MWLinkNodeInspector: Remove 'Open' button

https://gerrit.wikimedia.org/r/232653

gerritbot added a project: Patch-For-Review.Aug 19 2015, 10:59 PM
Krenair assigned this task to Jdforrester-WMF.Aug 21 2015, 7:27 PM
Krenair subscribed.
gerritbot added a comment.Aug 21 2015, 7:30 PM

Change 232653 merged by jenkins-bot:
MWLinkNodeInspector: Remove 'Open' button

https://gerrit.wikimedia.org/r/232653

Jdforrester-WMF mentioned this in rEVED55f78fcbf624: MWLinkNodeInspector: Remove 'Open' button.Aug 21 2015, 7:31 PM
Jdforrester-WMF closed this task as Resolved.Aug 21 2015, 7:31 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-08-25_(1.26wmf20); removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Esanders renamed this task from Remove "Open" button from MWExternalLinkNode inspector to Remove "Open" button from link inspecotrs.Aug 24 2015, 10:12 PM
Esanders reopened this task as Open.
Esanders subscribed.

Renamed bug to describe a consistent change across the link inspectors.

Personally I think the open button is useful (if misplaced on the internal inspector) for testing a link while editing.

gerritbot added a comment.Aug 24 2015, 10:14 PM

Change 233624 had a related patch set uploaded (by Esanders):
Revert "MWLinkNodeInspector: Remove 'Open' button"

https://gerrit.wikimedia.org/r/233624

gerritbot added a project: Patch-For-Review.Aug 24 2015, 10:14 PM
Jdforrester-WMF renamed this task from Remove "Open" button from link inspecotrs to Remove "Open" button from link inspectors.Aug 26 2015, 1:41 AM
Jdforrester-WMF added a parent task: T71690: Move buttons in the link editor away from underneath the input, as they're hidden by the pop-over suggestions.Sep 15 2015, 7:29 PM
Xinhuzhou moved this task from Needs Discussion/Analysis to TR3: Language support on the VisualEditor board.Sep 21 2015, 7:50 AM
Xinhuzhou moved this task from TR3: Language support to Needs Discussion/Analysis on the VisualEditor board.
Jdforrester-WMF renamed this task from Remove "Open" button from link inspectors to Remove "Open" button from all four link inspectors.Oct 6 2015, 12:19 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
DLynch claimed this task.Oct 7 2015, 3:59 PM
gerritbot added a comment.Oct 7 2015, 11:22 PM

Change 244373 had a related patch set uploaded (by DLynch):
Remove the "Open" button from link inspectors

https://gerrit.wikimedia.org/r/244373

gerritbot added a project: Patch-For-Review.Oct 7 2015, 11:22 PM
Esanders added a comment.Oct 7 2015, 11:36 PM

I have a related patch at https://gerrit.wikimedia.org/r/#/c/241699/ which removes the link behaviour from the search results. I don't think we should rely on right/middle click for useful functionality. If we are keeping a preview link feature it should be discoverable.

DLynch added a comment.Oct 8 2015, 12:01 AM

I was thinking of the clickable version of the link that appears in the context popup as being entirely suitable for the "I want to follow this" case. I can see how that doesn't work for the search results, though.

However, the existing "open" button is pretty awful if you want to use it for the search results, since (I believe) you have to click the result you want first, which populates the input and thus removes all your other results.

If we want to support this behavior in a more discoverable fashion, how about something inline in the search results which is more-explicitly an "open this link" action?

e.g.

With the link-symbol being an open-me target

pasted_file (268×429 px, 16 KB)

Or even more explicitly (and uglily)

pasted_file (268×429 px, 17 KB)

Jdforrester-WMF added a comment.Oct 8 2015, 2:13 PM

I agree with David that the Open button as-is is pretty useless; there may be a reason to add an "open" or "preview" secondary button to each search result, but the current one for the selected option adds no value.

Esanders added a comment.Oct 16 2015, 4:47 PM

Can we get a design pass at some sort of inline open button (maybe right aligned + frameless?)

gerritbot added a comment.Oct 16 2015, 4:51 PM

Change 244373 merged by jenkins-bot:
Remove the "Open" button from link inspectors

https://gerrit.wikimedia.org/r/244373

Jdforrester-WMF closed this task as Resolved.Oct 16 2015, 4:53 PM
Jdforrester-WMF mentioned this in T115726: Consider adding an explicit "open" button / affordance to lists of page results (link search, template search, etc.).
In T109646#1731111, @Esanders wrote:

Can we get a design pass at some sort of inline open button (maybe right aligned + frameless?)

Made that T115726: Consider adding an explicit "open" button / affordance to lists of page results (link search, template search, etc.).

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)); removed Patch-For-Review.Oct 16 2015, 4:53 PM
gerritbot added a comment.Oct 22 2015, 4:22 PM

Change 233624 abandoned by Jforrester:
Revert "MWLinkNodeInspector: Remove 'Open' button"

Reason:
Resolved, I think.

https://gerrit.wikimedia.org/r/233624

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL