Page MenuHomePhabricator
Create Task
Maniphest T109697

[Bug] suggestions show up twice in entity suggester
Closed, ResolvedPublic
Actions

Description

Search results in the property and item suggester show up twice.

to reproduce: type "occupant" into a property of type item-link. The same item will show up twice.

possibly related: T93571, T73100

Details

SubjectRepoBranchLines +/-
entityselector caches and shows search results twicemediawiki/extensions/Wikibasemaster+24 -1
Fixes:[Bug] suggestions show up twice in entity suggestermediawiki/extensions/Wikibasemaster+2 -8
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.Aug 20 2015, 10:39 AM
Lydia_Pintscher raised the priority of this task from to High.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Lydia_Pintscher subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2015, 10:39 AM
Addshore subscribed.Aug 20 2015, 10:40 AM

When changing a search from "Occupan" to "Occupant" in an entityselector box when editing an statement the UI will make the following calls:

  1. https://www.wikidata.org/w/api.php?action=wbsearchentities&search=occupant&format=json&language=en&type=item&continue=0
  2. https://www.wikidata.org/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=&options=%7B%22lang%22%3A%22en%22%7D
  3. https://www.wikidata.org/w/api.php?action=wbsearchentities&search=occupant&format=json&language=en&type=item&continue=0
  4. https://www.wikidata.org/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=Q7075751&options=%7B%22lang%22%3A%22en%22%7D
  5. https://www.wikidata.org/w/api.php?action=wbformatvalue&format=json&datavalue=%7B%22value%22%3A%7B%22entity-type%22%3A%22item%22%2C%22numeric-id%22%3A7075751%7D%2C%22type%22%3A%22wikibase-entityid%22%7D&options=%7B%22lang%22%3A%22en%22%7D&datatype=wikibase-item&generate=text%2Fhtml
  6. https://www.wikidata.org/w/api.php?action=wbformatvalue&format=json&datavalue=%7B%22value%22%3A%7B%22entity-type%22%3A%22item%22%2C%22numeric-id%22%3A7075751%7D%2C%22type%22%3A%22wikibase-entityid%22%7D&options=%7B%22lang%22%3A%22en%22%7D&datatype=wikibase-item&generate=text%2Fplain

The duplicate calls might not actually be the cause of the duplciates in the list, but nonetheless looks very odd...

Lydia_Pintscher updated the task description. (Show Details)Aug 20 2015, 10:40 AM
Lydia_Pintscher set Security to None.
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.
Josve05a subscribed.Aug 20 2015, 11:12 AM
Mbch331 subscribed.Aug 20 2015, 4:31 PM
• Spage mentioned this in T109800: [bug] items appear twice in search suggester dropdown after duplicate API request.Aug 21 2015, 1:55 AM
Sjoerddebruin subscribed.Aug 21 2015, 7:08 AM
• Jonas claimed this task.Aug 21 2015, 10:10 AM
• Jonas moved this task from consider for next sprint to in progress on the Wikidata board.
• Jonas added a project: Wikidata-Sprint-2015-08-18.
• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-18 board.
gerritbot subscribed.Aug 21 2015, 10:31 AM

Change 232916 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fixes:[Bug] suggestions show up twice in entity suggester

https://gerrit.wikimedia.org/r/232916

gerritbot added a project: Patch-For-Review.Aug 21 2015, 10:31 AM
• Jonas moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Aug 21 2015, 10:34 AM
thiemowmde closed this task as Resolved.Aug 21 2015, 10:53 AM
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.
thiemowmde subscribed.
gerritbot added a comment.Aug 21 2015, 10:55 AM

Change 232916 merged by jenkins-bot:
Fixes:[Bug] suggestions show up twice in entity suggester

https://gerrit.wikimedia.org/r/232916

Diffusion mentioned this in rMEXTfac4f8e69be8: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 21 2015, 10:55 AM
• Jonas mentioned this in rEWBAf99b50ee03d3: Fixes:[Bug] suggestions show up twice in entity suggester.Aug 21 2015, 10:55 AM
• Jonas changed the task status from Duplicate to Resolved.Aug 21 2015, 1:05 PM
• Jonas closed this task as a duplicate of T109800: [bug] items appear twice in search suggester dropdown after duplicate API request.
• Jonas merged a task: T109800: [bug] items appear twice in search suggester dropdown after duplicate API request.
• Jonas added subscribers: • Jonas, • Spage.
Lydia_Pintscher merged a task: T109948: Suggestions doubled.Aug 23 2015, 12:21 PM
Lydia_Pintscher added a subscriber: Raymond.
Ricordisamoa removed a project: Patch-For-Review.Aug 24 2015, 12:42 PM
Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot.
thiemowmde reopened this task as Open.Jul 1 2016, 11:03 AM
thiemowmde claimed this task.
thiemowmde added projects: Wikidata-Sprint-2016-05-24, Patch-For-Review.
gerritbot added a comment.Jul 1 2016, 11:05 AM

Change 296880 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
entityselector caches and shows search results twice

https://gerrit.wikimedia.org/r/296880

thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-24 board.Jul 1 2016, 11:06 AM
gerritbot added a comment.Jul 5 2016, 9:08 AM

Change 296880 merged by jenkins-bot:
entityselector caches and shows search results twice

https://gerrit.wikimedia.org/r/296880

thiemowmde closed this task as Resolved.Jul 5 2016, 12:49 PM
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2016-05-24 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL