Page MenuHomePhabricator
Create Task
Maniphest T109904

Regression: In stable last modified bar padding broken
Closed, ResolvedPublic
Actions

Description

Introduced in:
Remove the experimental header from alpha and beta

Bug: T108988
Change-Id: I4a201c46bf87832902c50122a6da56dd97322d77

Revert or fixup?

Note the difference between:

Screen Shot 2015-08-21 at 2.45.23 PM.png (138×457 px, 15 KB)
&
Screen Shot 2015-08-21 at 2.44.17 PM.png (112×683 px, 12 KB)

Details

SubjectRepoBranchLines +/-
Bring back the last modified bar padding in betamediawiki/extensions/MobileFrontendmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 21 2015, 9:45 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Reading-Web-Sprint-54-28-Days-Later.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-54-28-Days-Later board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2015, 9:45 PM
Jdlrobson mentioned this in T108988: Remove beta header, clean up code.Aug 21 2015, 9:46 PM
Aklapper added a project: Regression.Aug 21 2015, 10:27 PM
• Jhernandez triaged this task as Unbreak Now! priority.Aug 24 2015, 9:25 AM
• Jhernandez set Security to None.
• Jhernandez added a parent task: T108988: Remove beta header, clean up code.
• Jhernandez added subscribers: • Jhernandez, • bmansurov.

@Jdlrobson Either fix it up or revert before tomorrow's branch cut.

I'd love to get it fixed and the header removed as a preference. Let's see if we can fix it today.

• bmansurov claimed this task.Aug 24 2015, 10:21 AM
gerritbot subscribed.Aug 24 2015, 10:48 AM

Change 233379 had a related patch set uploaded (by Bmansurov):
Bring back the last modified bar padding in beta

https://gerrit.wikimedia.org/r/233379

gerritbot added a project: Patch-For-Review.Aug 24 2015, 10:48 AM
• bmansurov moved this task from To Do to Code Review on the Reading-Web-Sprint-54-28-Days-Later board.Aug 24 2015, 10:49 AM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-54-28-Days-Later board.Aug 24 2015, 6:41 PM
Jdlrobson mentioned this in rEMFRa11aca53b64a: Bring back the last modified bar padding in beta.Aug 24 2015, 6:49 PM
• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 24 2015, 7:00 PM
• Jhernandez closed this task as Resolved.Aug 25 2015, 11:08 AM

Seems to be fine locally. Can't verify on BC because it's borked.

• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-54-28-Days-Later board.Aug 25 2015, 11:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL