Page MenuHomePhabricator
Create Task
Maniphest T110358

Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing"
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Quiddity
Aug 26 2015, 5:43 PM
Tags
Referenced Files
F2390030: Screen Shot 2015-08-26 at 12.44.53 PM.png
Aug 26 2015, 7:52 PM
F2390739: Screen Shot 2015-08-26 at 12.51.09 PM.png
Aug 26 2015, 7:52 PM
F2379613: m7RNFj9.png
Aug 26 2015, 5:43 PM
Subscribers
Aklapper
• DannyH
Etonkovidova
gerritbot
• Mattflaschen-WMF
Quiddity

Description

If I edit an empty board description, and click "Save description", I get the message Previous revision identifier is missing

m7RNFj9.png (569×600 px, 45 KB)

Reproduced at https://www.mediawiki.org/wiki/Talk:Sandbox
and https://lv.wikipedia.org/wiki/Vikip%C4%93dijas_diskusija:Flow

If I blank an existing description, that does Not cause the bug to appear.
However https://www.mediawiki.org/wiki/Talk:Sandbox used to have a description until 2 days ago, so that's odd...

Ah, I replicated part of the edits from Talk:Sandbox at https://www.mediawiki.org/wiki/User_talk:Quiddity_%28WMF%29 by adding [[Category:Flow|*]] and then deleting it, and now that page is also suffering the bug.

Details

SubjectRepoBranchLines +/-
Populate the Description data model even if content is emptymediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Aug 26 2015, 5:43 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Quiddity subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2015, 5:43 PM
Quiddity renamed this task from Editing an empty Flow board description gives "Previous revision identifier is missing" to Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing".Aug 26 2015, 5:44 PM
Quiddity set Security to None.
Catrope assigned this task to Mooeypoo.Aug 26 2015, 5:48 PM
Etonkovidova subscribed.EditedAug 26 2015, 7:52 PM

In betalabs it happens only when a board description has a template(any template) and that template was deleted and 'Save changes' was clicked:

  1. Delete a content from a board descirption.
  2. In wikitext mode - add [[Category:Flow|*]] - click on 'Save description'

The following error is displayed:
[32ec9d4d] Exception Caught: Row has null primary key:

In Console: Uncaught Error: ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds
ve.dm.Document.getBranchNodeFromOffset @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:189ve.dm.Surface.setSelection @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:152ve.dm.SurfaceFragment.select @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:166ve.ce.Surface.handleLinearDelete @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:410ve.ce.Surface.onDocumentKeyDown @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:366ve.EventSequencer.callListener @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:44ve.EventSequencer.onEvent @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:41ve.EventSequencer.pendingCalls @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:39jQuery.event.dispatch @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3vxc1Hwb:65jQuery.event.add.elemData.handle @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3vxc1Hwb:60

Uncaught Error: Invalid start offset: -1ve.Document.selectNodes @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:31ve.dm.SurfaceFragment.getSelectedNode @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:165ve.dm.SurfaceFragment.getSelectedModels @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:158ve.ui.LinearContext.getRelatedSources @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:470ve.ui.LinearContext.isInspectable @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:470ve.ui.LinearContext.afterContextChange @ load.php?debug=false&lang=en&modules=ext.flow.editors.none|ext.flow.visualEditor|ext.visualEditor.c…:469mw.loader.implement.ve.ui.DesktopContext.afterContextChange @ VM3297:116

Screen Shot 2015-08-26 at 12.44.53 PM.png (415×395 px, 39 KB)

Screen Shot 2015-08-26 at 12.51.09 PM.png (605×399 px, 67 KB)

Etonkovidova added a comment.Aug 26 2015, 8:09 PM

If I blank an existing description, that does Not cause the bug to appear.

I thought that it was never allowed to create Flow pages in production with an empty board description. If at some point, an empty board description was created and then it was disallowed, it might explain 'Previous revision identifier is missing".

• Mattflaschen-WMF subscribed.Aug 26 2015, 8:38 PM
In T110358#1576824, @Etonkovidova wrote:

I thought that it was never allowed to create Flow pages in production with an empty board description.

No, you can still create it by creating a topic.

gerritbot subscribed.Aug 26 2015, 8:43 PM

Change 234135 had a related patch set uploaded (by Mooeypoo):
Populate the Description data model even if content is empty

https://gerrit.wikimedia.org/r/234135

gerritbot added a project: Patch-For-Review.Aug 26 2015, 8:43 PM
gerritbot added a comment.Aug 26 2015, 8:49 PM

Change 234135 merged by jenkins-bot:
Populate the Description data model even if content is empty

https://gerrit.wikimedia.org/r/234135

Diffusion mentioned this in rMEXT2e3070143a70: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 26 2015, 8:49 PM
Mooeypoo mentioned this in rEFLW42968f8a9b5e: Populate the Description data model even if content is empty.Aug 26 2015, 8:49 PM
• Forrestbot added a project: WMF-deploy-2015-09-01_(1.26wmf21).Aug 26 2015, 9:00 PM
Mooeypoo moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 27 2015, 5:01 PM
• DannyH triaged this task as Unbreak Now! priority.Aug 27 2015, 5:02 PM
• DannyH moved this task from QA Review to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
• DannyH moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.
• DannyH subscribed.
• Mattflaschen-WMF added a comment.Aug 27 2015, 6:46 PM
In T110358#1576773, @Etonkovidova wrote:

In betalabs it happens only when a board description has a template(any template) and that template was deleted and 'Save changes' was clicked:

  1. Delete a content from a board descirption.
  2. In wikitext mode - add [[Category:Flow|*]] - click on 'Save description'

The following error is displayed:
[32ec9d4d] Exception Caught: Row has null primary key:

Filed as T110390: Exception Caught: Row has null primary key.

In Console: Uncaught Error: ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds

Filed as T110393: VE error editing board description.

• Mattflaschen-WMF mentioned this in T110393: VE error editing board description.Aug 27 2015, 6:50 PM
• DannyH added a project: OKR-Work.Aug 27 2015, 7:02 PM
Etonkovidova added a comment.Aug 28 2015, 4:03 PM

Checked in betalabs. Since other bugs were filed separately T110390: Exception Caught: Row has null primary key T110393: VE error editing board description - this issue was just verified for new empty board to which [[Category:Flow|*]] was added.

Also, empty new boards were tested for links/mention.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 28 2015, 4:04 PM
• DannyH closed this task as Resolved.Aug 28 2015, 5:21 PM
Etonkovidova added a comment.EditedAug 31 2015, 4:55 PM

Re-checked in betalabs - the specific error is not present anymore.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL