Page MenuHomePhabricator

Split notifications: minor display issues
Closed, ResolvedPublic

Description

1) The bell icon for Alerts stays in unseen state
From

.mw-echo-ui-notificationBadgeButtonPopupWidget-alert.oo-ui-flaggedElement-unseen > .oo-ui-buttonElement-button {
    background-color: #D11813;

After clicking on Alerts with red&unseen(inverted) icon - there'll still be the unseen img but displayed on a grey background:

.mw-echo-ui-notificationBadgeButtonPopupWidget > .oo-ui-buttonElement-button {
    border-radius: 0.2em;
    background-color: #d2d2d2;

Only after refreshing the page the unseen image changes:

2) The upper horizontal line is not present anymore

mediawiki

3) The small cross icon to mark a message as Read is placed too closely to the right edge. Look at the previous screenshot.
However, if click in the box, or hover - the cross icons moved away from the edge:

Event Timeline

Etonkovidova updated the task description. (Show Details)
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova added a subscriber: Etonkovidova.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2015, 7:29 PM
Catrope added a subscriber: Catrope.Sep 3 2015, 8:33 PM

Is #3 specific to Chrome?

Is #3 specific to Chrome?

It's happening because we're redrawing after the silly scrollbars appear :(
I don't know how to fix it except for showing scrollbars regardless and then getting rid of them after load or something hacky like that.

Is #3 specific to Chrome?

It's happening because we're redrawing after the silly scrollbars appear :(
I don't know how to fix it except for showing scrollbars regardless and then getting rid of them after load or something hacky like that.

I think there's a limit to how much time we have to spend working around bugs in specific browsers.

Yes, #3 seems to be specific to Chrome.

There is another teeny-tiny annoyance which presents only in FF - watch for a space above number in small notification counter boxes.

Change 235885 had a related patch set uploaded (by Mooeypoo):
Fix the badge icon update

https://gerrit.wikimedia.org/r/235885

Change 235891 had a related patch set uploaded (by Mooeypoo):
Add a border between the popup head and notification list

https://gerrit.wikimedia.org/r/235891

Change 235891 merged by jenkins-bot:
Add a border between the popup head and notification list

https://gerrit.wikimedia.org/r/235891

Change 235885 merged by jenkins-bot:
Fix the badge icon update

https://gerrit.wikimedia.org/r/235885

Checked in betalabs in Chrome and FF.

DannyH closed this task as Resolved.Sep 9 2015, 5:34 PM
DannyH added a subscriber: DannyH.

Beautiful, thank you for the super fast discovery, diagnosis and fix.

Luke081515 added a subscriber: Luke081515.