Split notifications: minor display issues
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 3 2015, 7:29 PM

Description

1) The bell icon for Alerts stays in unseen state
From

.mw-echo-ui-notificationBadgeButtonPopupWidget-alert.oo-ui-flaggedElement-unseen > .oo-ui-buttonElement-button {
    background-color: #D11813;

After clicking on Alerts with red&unseen(inverted) icon - there'll still be the unseen img but displayed on a grey background:

.mw-echo-ui-notificationBadgeButtonPopupWidget > .oo-ui-buttonElement-button {
    border-radius: 0.2em;
    background-color: #d2d2d2;

Only after refreshing the page the unseen image changes:

Screen Shot 2015-09-03 at 12.17.56 PM.png (179×626 px, 28 KB)

2) The upper horizontal line is not present anymore

Screen Shot 2015-09-03 at 12.00.16 PM.png (444×555 px, 75 KB)

mediawiki

Screen Shot 2015-09-03 at 10.14.28 AM.png (478×615 px, 112 KB)

3) The small cross icon to mark a message as Read is placed too closely to the right edge. Look at the previous screenshot.
However, if click in the box, or hover - the cross icons moved away from the edge:

Screen Shot 2015-09-03 at 12.00.29 PM.png (462×542 px, 75 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix the badge icon update	mediawiki/extensions/Echo	master	+30 -20
	Add a border between the popup head and notification list	mediawiki/extensions/Echo	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rECHO36191fc29063: Fix the badge icon update
rMEXT3c7e669ff793: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…
rECHO820eaa2726de: Add a border between the popup head and notification list
rMEXT82460509f5ae: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…
T108190: Split notifications into Alerts and Messages

Event Timeline

Etonkovidova created this task.Sep 3 2015, 7:29 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Triage.

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2015, 7:29 PM

Is #3 specific to Chrome?

In T111432#1604118, @Catrope wrote:

Is #3 specific to Chrome?

It's happening because we're redrawing after the silly scrollbars appear :(
I don't know how to fix it except for showing scrollbars regardless and then getting rid of them after load or something hacky like that.

In T111432#1604134, @Mooeypoo wrote:

In T111432#1604118, @Catrope wrote:

Is #3 specific to Chrome?

It's happening because we're redrawing after the silly scrollbars appear :(
I don't know how to fix it except for showing scrollbars regardless and then getting rid of them after load or something hacky like that.

I think there's a limit to how much time we have to spend working around bugs in specific browsers.

Etonkovidova mentioned this in T108190: Split notifications into Alerts and Messages.Sep 3 2015, 8:45 PM

Yes, #3 seems to be specific to Chrome.

There is another teeny-tiny annoyance which presents only in FF - watch for a space above number in small notification counter boxes.

Screen Shot 2015-09-03 at 1.52.41 PM.png (164×629 px, 43 KB)

Screen Shot 2015-09-03 at 1.52.16 PM.png (204×641 px, 62 KB)

Change 235885 had a related patch set uploaded (by Mooeypoo):
Fix the badge icon update

https://gerrit.wikimedia.org/r/235885

gerritbot added a project: Patch-For-Review.Sep 3 2015, 9:25 PM

Change 235891 had a related patch set uploaded (by Mooeypoo):
Add a border between the popup head and notification list

https://gerrit.wikimedia.org/r/235891

Change 235891 merged by jenkins-bot:
Add a border between the popup head and notification list

https://gerrit.wikimedia.org/r/235891

Diffusion mentioned this in rMEXT82460509f5ae: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 3 2015, 9:35 PM

Mooeypoo mentioned this in rECHO820eaa2726de: Add a border between the popup head and notification list.Sep 3 2015, 9:35 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 3 2015, 10:00 PM

Change 235885 merged by jenkins-bot:
Fix the badge icon update

https://gerrit.wikimedia.org/r/235885

Diffusion mentioned this in rMEXT3c7e669ff793: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 7 2015, 7:11 PM

Mooeypoo mentioned this in rECHO36191fc29063: Fix the badge icon update.Sep 7 2015, 7:12 PM

Mooeypoo claimed this task.Sep 8 2015, 1:13 AM

Mooeypoo edited projects, added Collaboration-Team-Archive-2015-2016, Notifications; removed Collaboration-Team-Triage, StructuredDiscussions.

Mooeypoo set Security to None.

Mooeypoo moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.

Checked in betalabs in Chrome and FF.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 8 2015, 11:35 PM

Beautiful, thank you for the super fast discovery, diagnosis and fix.

Luke081515 awarded a token.Sep 9 2015, 8:22 PM

Luke081515 subscribed.

	F2538347: Screen Shot 2015-09-03 at 1.52.16 PM.png
	Sep 3 2015, 9:02 PM

	F2538346: Screen Shot 2015-09-03 at 1.52.41 PM.png
	Sep 3 2015, 9:02 PM

	F2538118: Screen Shot 2015-09-03 at 10.12.02 AM.png
	Sep 3 2015, 7:29 PM

	F2538137: Screen Shot 2015-09-03 at 12.00.29 PM.png
	Sep 3 2015, 7:29 PM

	F2538124: Screen Shot 2015-09-03 at 12.16.54 PM.png
	Sep 3 2015, 7:29 PM

	F2538134: Screen Shot 2015-09-03 at 10.14.28 AM.png
	Sep 3 2015, 7:29 PM

	F2538131: Screen Shot 2015-09-03 at 12.00.16 PM.png
	Sep 3 2015, 7:29 PM

	F2538126: Screen Shot 2015-09-03 at 12.17.56 PM.png
	Sep 3 2015, 7:29 PM

Split notifications: minor display issuesClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Split notifications: minor display issues
Closed, ResolvedPublic
Actions