Page MenuHomePhabricator
Create Task
Maniphest T111987

[Regression] Editing upper post in nested thread opens all nested Replies
Closed, ResolvedPublic
Actions

Description

  1. Create Reply structure as in the screenshot, i.e. Reply to a topic and then create three replies for the first one by clicking at 'Reply' under the initial Reply

Screen Shot 2015-09-09 at 11.45.27 AM.png (508×1 px, 63 KB)

  1. Click on the upper most Reply to Edit. All nested Replies will be open with empty content. They cannot be canceled and the page needs to be refreshed. In the screenshot, see how the original Reply "test" is placed.

Screen Shot 2015-09-09 at 11.47.04 AM.png (655×1 px, 61 KB)

Details

SubjectRepoBranchLines +/-
Don't open multiple editors when editing posts that have repliesmediawiki/extensions/Flowwmf/1.26wmf22+1 -1
Don't open multiple editors when editing posts that have repliesmediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 9 2015, 6:59 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: Collaboration-Team-Triage, StructuredDiscussions.
Etonkovidova added subscribers: Aklapper, Etonkovidova.
Etonkovidova mentioned this in T101316: Make the VE/source toggle more discoverable.Sep 9 2015, 9:07 PM
gerritbot subscribed.Sep 9 2015, 10:53 PM

Change 237288 had a related patch set uploaded (by Catrope):
Don't open multiple editors when editing posts that have replies

https://gerrit.wikimedia.org/r/237288

gerritbot added a project: Patch-For-Review.Sep 9 2015, 10:53 PM
gerritbot added a comment.Sep 9 2015, 10:57 PM

Change 237288 merged by jenkins-bot:
Don't open multiple editors when editing posts that have replies

https://gerrit.wikimedia.org/r/237288

Catrope mentioned this in rEFLWcce1514f8bc3: Don't open multiple editors when editing posts that have replies.Sep 9 2015, 10:57 PM
Catrope mentioned this in rMEXTa1c3fc17aae4: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
gerritbot added a comment.Sep 9 2015, 11:01 PM

Change 237290 had a related patch set uploaded (by Catrope):
Don't open multiple editors when editing posts that have replies

https://gerrit.wikimedia.org/r/237290

gerritbot added a comment.Sep 9 2015, 11:09 PM

Change 237290 merged by jenkins-bot:
Don't open multiple editors when editing posts that have replies

https://gerrit.wikimedia.org/r/237290

Diffusion mentioned this in rMW8cb8a7f91889: Updated mediawiki/core Project: mediawiki/extensions/Flow….Sep 9 2015, 11:09 PM
Catrope mentioned this in rEFLW85b0dff2fe59: Don't open multiple editors when editing posts that have replies.Sep 9 2015, 11:09 PM
Etonkovidova edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Sep 10 2015, 6:43 PM
Etonkovidova set Security to None.
ReleaseTaggerBot added projects: WMF-deploy-2015-09-15_(1.26wmf23), WMF-deploy-2015-09-08_(1.26wmf22).Sep 10 2015, 10:02 PM
Mooeypoo assigned this task to Catrope.Sep 10 2015, 10:44 PM
Mooeypoo moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
Etonkovidova added a comment.Sep 11 2015, 4:54 PM

Checked in betalabs.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 11 2015, 4:55 PM
Aklapper added a comment.Sep 11 2015, 8:52 PM
In T111987#1631150, @Etonkovidova wrote:

Checked in betalabs.

@Etonkovidova: If you checked, what was the result of your check?

• Mattflaschen-WMF subscribed.Sep 11 2015, 8:55 PM
In T111987#1632410, @Aklapper wrote:
In T111987#1631150, @Etonkovidova wrote:

Checked in betalabs.

@Etonkovidova: If you checked, what was the result of your check?

It passed. She will say if there is a failure. Also, you can tell because she moved it to Product Review, meaning QA Review is completed without finding problems.

• DannyH closed this task as Resolved.Sep 14 2015, 5:31 PM
• DannyH subscribed.

I double-checked in Beta, this is fixed. :)

• DannyH added a project: OKR-Work.Sep 14 2015, 10:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL