Page MenuHomePhabricator

Echo waits to show you messages on second load
Closed, ResolvedPublic

Description

We have a loading animation that shows while messages are being loaded. When you open either window for the second time, the loading animation shows again which seems odd given then you just had it open a few seconds ago.

Even if we do need to refresh the list every time it is opened, we can still show the notifications from the last time it was opened, and then if the second fetch gives us more results, we can transition those in.

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: Notifications.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The notification widget is, by request/design, updating itself on every open. The ideal would be that echo API gives us only the *NEW* notifications instead of always reloading the entire notification list, but that is a feature that's currently missing from Echo (and is being worked on)

So while that's being developed, the idea was to let the user know that the notifications are reloading. We could show the previous list, but won't that be even more confusing? To have a list, and the suddenly have it change without warning?

Change 237522 had a related patch set uploaded (by Mooeypoo):
Don't clear notifications when refetching

https://gerrit.wikimedia.org/r/237522

Change 237522 merged by jenkins-bot:
Don't clear notifications when refetching

https://gerrit.wikimedia.org/r/237522

Checked in betalabs.

There is a slight issue with Alerts - if there are some unseen Alerts and another Alert happened, then when clicking on Alerts a red button is display briefly, the number momentarily changes and only then Alerts dim. Attached is the screencast