Check if using repo edit summaries on client works with different versions of the code and old data.
Verify special cases (especially linking/unlinking of the local page) get handled correctly.
Make sure it works correctly with "coalesced" changes too (when multiple consecutive edits by a single user get combined on the client).
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Track usage of missign entity via Lua. | mediawiki/extensions/Wikibase | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T90435 [Epic] Wikidata watchlist improvements (client) | |||
| Open | None | T108688 [Story] meaningful edit summaries on the client | |||
| Resolved | None | T112649 [Task] Test: Using repo edit summaries on the client | |||
| Resolved | hoo | T114664 [Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo | |||
| Invalid | None | T114665 [Bug] Repo should generate a meaningful log message when an entity is deleted. | |||
| Invalid | None | T114666 [Bug] Repo should generate a meaningful log message when an entity is restored | |||
| Invalid | None | T114668 [Bug] Show meaningful message on the client when a used (but not connected) entity is deleted or restored. | |||
| Invalid | None | T114670 [Bug] Improve display of relevant item ID in RecentChanges/Watchlist display on the client. | |||
| Resolved | daniel | T114697 [Bug] wbc_entity_usage table gets new rows with ancient eu_touched date |
Event Timeline
Comment Actions
Tested latest code. No errors so far.
Things that don't work:
- No working links or labels on the recent changes page.
- No info about new site links on pages that are not site linked.
- Generic info about qualifier and rank changes (changed claim)
- Sitelink but no usage of data -> only info about site link changes
Comment Actions
Lua integration is not working for my current setup (client+repo= same wiki), so somebody else has to test this aspect.
Comment Actions
Change 243660 had a related patch set uploaded (by Daniel Kinzler):
Track usage of missign entity via Lua.
Comment Actions
Decision made during todays story time:
- Picked for the current sprint and considered a blocker for deployment: T114697: [Bug] wbc_entity_usage table gets new rows with ancient eu_touched date.
- Also a blocker: T114664: [Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo.
- @Lydia_Pintscher wants to see in person: T114665: [Bug] Repo should generate a meaningful log message when an entity is deleted. and T114666: [Bug] Repo should generate a meaningful log message when an entity is restored.
- Not a blocking task: T114668: [Bug] Show meaningful message on the client when a used (but not connected) entity is deleted or restored.
- Need to talk about and figure out a good way: T114670: [Bug] Improve display of relevant item ID in RecentChanges/Watchlist display on the client.
Comment Actions
Update:
- T114665 and T114666 are actual bugs and should be fixed, but do not block deployment. They are low impact assuming that items that are still used on client pages are rarely deleted (and even more rarely restored).
- T114664 was reduced to a non-blocker since the information provided is not wrong. The point here is merely to improve consistency.
Comment Actions
So we should redo the testing after all blocking bugs are fixed. I would propose at least two people other than daniel and me should do the tests.
Comment Actions
think this is already reported but links in edit summaries don't work for me.
they just take me to my base repo url.
Comment Actions
(diff | hist) . . D Grover Cleveland (Q207); 21:59 . . 127.0.0.1 (Talk) (Language link removed: az:Qrover Klivlend; Language link removed: bar:Stephen Grover Cleveland; Language link removed: bcl:Grover Cleveland; Language link removed: bg:Гроувър Кливланд)
would be nicer if it was "Language links removed: az:Qrover Klivlend, bar:Stephen Grover Cleveland, bcl:Grover Cleveland, bg:Гроувър Кливланд"
Comment Actions
also, the summaries can be a bit lengthy, overwhelming and somewhat confusing:
Changed claim: Property:P8: 2--74; Changed [en] description: country in North Americgkjwgljdsklgjsdklgjskdlgjskdlgjlskdjgldskjgklsdjglskdjglskdijgkdlsjgklsjglskgjsa; Changed [en] description: country in North Americgkjwgljdsklggsgjsdklgjskdlgjskdlgjlskdjgldskjgklsdjglskdjglskdijgkdlsjgklsjglskgjsa; Changed [en] description: country in North hfd; Changed [en] description: country in North; Changed [en] description: country in North America; Setting [en] aliases: USA, America, the States, U.S., U.S.A., United States, 🇺🇸, USs; Setting [en] aliases: USA, America, the States, U.S., U.S.A., United States, 🇺🇸, US; Setting [en] aliases: USA, America, the States, U.S., U.S.A., United State)
i probably changed the description multiple times, but listing them all like this is a bit much and is not very understandable to me
Comment Actions
i am also not a fan of having the class="external" formatting on links. interwiki links for site link changes don't have this. (e.g. Language link removed: az:Qrover Klivlend;)
they should at least be consistent, and as an interwiki link, I think not be marked as external. (although others might disagree)