A pixel or two too low:
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MediaWiki theme: Ensure vertical alignment of dialog top bar items | oojs/ui | master | +11 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T130691 Sub-pixel rendering layout issues with `em` or `%` relative units (tracking) | |||
| Resolved | Volker_E | T113469 ProcessDialog: Vertical alignment of buttons off |
Event Timeline
Comment Actions
Change 240384 had a related patch set uploaded (by Jforrester):
Fix icon/indicator padding on TextInputWidget/SelectFileWidget
Comment Actions
Might be connected to the recent change of switching over to more padding related vertical text alignment?
Also: T115179: Vertical alignment of DropdownWidget handles off in MediaWiki theme
Comment Actions
@Jdforrester-WMF No, it's not. It doesn't look like the button is too low at top, but it's takes up a bit too much height altogether and doesn't get appropriate padding-bottom (distance to the bottom). It starts at the right top point, but goes .x pixels too far down.
After looking just for a minute at it, it's another bug related to the cumbersome inabilities [[ https://phabricator.wikimedia.org/T130691 | to handle ems in general appropriately ]].
Comment Actions
Change 342507 had a related patch set uploaded (by VolkerE):
[oojs/ui] MediaWiki theme: Ensure vertical alignment of dialog top bar items
Comment Actions
Change 342507 merged by jenkins-bot:
[oojs/ui] MediaWiki theme: Ensure vertical alignment of dialog top bar items