Maniphest T113518

trailing \n appearing at the bottom of search results pages on mediawiki.org and meta.wikimedia.org
Closed, ResolvedPublic
Actions

Description

Below the results, but above the navigation controls at the bottom of the page, a \n appears.

This does not appear to be happening on en.wikipedia.org.

https://en.wikipedia.org/w/index.php?search=test+search&title=Special%3ASearch&go=Go

I can also reproduce this issue locally using the tip of master:

Screen Shot 2015-09-23 at 13.03.59.png (868×1 px, 121 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix stray literal \n in output	mediawiki/core	REL1_26	+2 -1
	Fix stray literal \n in output	mediawiki/core	master	+1 -1
	Fix stray literal \n in output	mediawiki/core	wmf/1.26wmf24	+1 -1
	Fix trailing \n on Special:Search.	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T123963: SpecialSearch.php prints a plain "\n" at the bottom of a page
T119879: Search result columns in 1.26.0 not correctly display when using both title and text scope
rMWd0299c7c591e: Fix stray literal \n in output
rMWbb901c66e5aa: Fix stray literal \n in output
T87631: Interwiki search results should come after local ones in HTML

Event Timeline

• Deskana created this task.Sep 23 2015, 8:04 PM

• Deskana raised the priority of this task from to Medium.

• Deskana updated the task description. (Show Details)

• Deskana added projects: Discovery-ARCHIVED, Discovery-Search (Current work).

• Deskana subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2015, 8:04 PM

Someone probably did '\n' instead of "\n"?

Krenair subscribed.Sep 23 2015, 8:15 PM

This seems to be caused by this patch: https://gerrit.wikimedia.org/r/#/c/238808/

Krenair mentioned this in T87631: Interwiki search results should come after local ones in HTML.Sep 23 2015, 9:12 PM

Change 240590 had a related patch set uploaded (by EBernhardson):
Fix stray literal \n in output

https://gerrit.wikimedia.org/r/240590

Change 240591 had a related patch set uploaded (by Deskana):
Fix trailing \n on Special:Search.

https://gerrit.wikimedia.org/r/240591

Okay, whoever reviews this can decide which of the two solutions is best. ;-)

Change 240590 merged by jenkins-bot:
Fix stray literal \n in output

https://gerrit.wikimedia.org/r/240590

EBernhardson mentioned this in rMWbb901c66e5aa: Fix stray literal \n in output.Sep 23 2015, 9:55 PM

Change 240591 abandoned by Deskana:
Fix trailing \n on Special:Search.

Reason:
Unnecessary; Ia4591849f7675ad062210f21ff6273077a198704 was merged which fixed this problem.

https://gerrit.wikimedia.org/r/240591

Change 240596 had a related patch set uploaded (by Alex Monk):
Fix stray literal \n in output

https://gerrit.wikimedia.org/r/240596

Change 240596 merged by Alex Monk:
Fix stray literal \n in output

https://gerrit.wikimedia.org/r/240596

Krenair mentioned this in rMWd0299c7c591e: Fix stray literal \n in output.Sep 23 2015, 11:15 PM

Krenair closed this task as Resolved.Sep 23 2015, 11:17 PM

Krenair claimed this task.

Krenair reassigned this task from Krenair to EBernhardson.

Krenair set Security to None.

Thanks for the backport and deploy, @Krenair!

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 24 2015, 12:01 AM

• Deskana moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Sep 24 2015, 12:02 AM

• Deskana moved this task from Needs Reporting to Resolved on the Discovery-Search (Current work) board.Sep 24 2015, 4:07 AM

Nemo_bis added a project: MediaWiki-Search.Sep 24 2015, 6:30 AM

Trijnstel subscribed.Sep 24 2015, 3:42 PM

• MZMcBride subscribed.Sep 25 2015, 4:24 AM

ReleaseTaggerBot added projects: WMF-deploy-2015-09-22_(1.26wmf24), MW-1.27-release, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 8:02 PM

greg edited projects, added MW-1.27-release-notes; removed MW-1.27-release.Sep 29 2015, 10:27 PM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM

Change 255654 had a related patch set uploaded (by Legoktm):
Fix stray literal \n in output

https://gerrit.wikimedia.org/r/255654

Change 255654 merged by jenkins-bot:
Fix stray literal \n in output

https://gerrit.wikimedia.org/r/255654

• Deskana mentioned this in T119879: Search result columns in 1.26.0 not correctly display when using both title and text scope.Dec 3 2015, 3:10 AM

• Deskana mentioned this in T123963: SpecialSearch.php prints a plain "\n" at the bottom of a page.Jan 18 2016, 8:59 PM

• Deskana merged a task: T123963: SpecialSearch.php prints a plain "\n" at the bottom of a page.

• Deskana added subscribers: Tormate, StudiesWorld.