Page MenuHomePhabricator
Create Task
Maniphest T113620

MultimediaViewer browser tests should run on a per commit basis
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Process all documented here:
https://www.mediawiki.org/wiki/Continuous_integration/Browser_tests https://www.mediawiki.org/wiki/Reading/Web#QA
Let's make this happen.

Add the @integration tag to things that are passin.

If any tests are currently failing please update T94157 with specifics.

Details

SubjectRepoBranchLines +/-
Add integration tests to each commitmediawiki/extensions/MultimediaViewermaster+46 -13
Run MultimediaViewer browser tests on each commitintegration/configmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 24 2015, 3:56 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: MediaViewer.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 3:56 PM
Jdlrobson added a subtask: T94157: Fix MultimediaViewer scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily.Sep 24 2015, 3:56 PM
Jdlrobson updated the task description. (Show Details)Dec 21 2015, 4:59 PM
Jdlrobson added a project: Reading-Web-Sprint-63-Ellip….
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-63-Ellip… board.Dec 21 2015, 5:24 PM
• KLans_WMF moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-63-Ellip… board.Dec 21 2015, 5:25 PM
Jdlrobson updated the task description. (Show Details)Dec 21 2015, 5:28 PM
• KLans_WMF edited a custom field.Dec 21 2015, 5:30 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-63-Ellip… board.Dec 21 2015, 5:30 PM
Jdlrobson added a parent task: T55697: [EPIC] trigger browser tests from Gerrit (tracking).Dec 23 2015, 9:45 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-63-Ellip… board.Dec 23 2015, 9:52 PM
gerritbot subscribed.Dec 23 2015, 9:52 PM

Change 260866 had a related patch set uploaded (by Jdlrobson):
Run MultimediaViewer browser tests on each commit

https://gerrit.wikimedia.org/r/260866

gerritbot added a project: Patch-For-Review.Dec 23 2015, 9:52 PM
Jdlrobson claimed this task.Dec 23 2015, 9:53 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 23 2015, 10:47 PM
gerritbot added a comment.Dec 23 2015, 11:12 PM

Change 260866 merged by jenkins-bot:
Run MultimediaViewer browser tests on each commit

https://gerrit.wikimedia.org/r/260866

gerritbot added a comment.Dec 24 2015, 12:11 AM

Change 260881 had a related patch set uploaded (by Jdlrobson):
Add integration tests to each commit

https://gerrit.wikimedia.org/r/260881

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-63-Ellip… board.Dec 24 2015, 12:19 AM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-63-Ellip… board.
• bmansurov subscribed.Dec 24 2015, 11:34 AM

A test is failing: https://integration.wikimedia.org/ci/job/mwext-mw-selenium/2603/console

• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-63-Ellip… board.Dec 24 2015, 11:34 AM
Jdlrobson added a comment.Dec 24 2015, 2:47 PM

Hmm can't replicate locally but see there is a php warning on the file page https://integration.wikimedia.org/ci/job/mwext-mw-selenium/2603/artifact/log/Options%3A%20Disabling%20media%20viewer%20makes%20the%20next%20thumbnail%20click%20go%20to%20the%20file%20page.png
.
Have tried re-running it...

Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-63-Ellip… board.Dec 24 2015, 3:14 PM
• Tgr subscribed.Dec 24 2015, 8:07 PM

Looks like a directory permission issue.

I really, really recommend using vagrant as your test environment. You don't want to spend your time debugging while the tests behave differently on your test runner machine than locally.

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-63-Ellip… board.Dec 28 2015, 5:57 PM
Jdlrobson added a comment.Dec 28 2015, 7:39 PM

@Tgr I'm sure the release engineering who are already overstretched would welcome some help with that :)
https://gerrit.wikimedia.org/r/260881 is passing now

gerritbot added a comment.Jan 27 2016, 6:24 PM

Change 260881 merged by jenkins-bot:
Add integration tests to each commit

https://gerrit.wikimedia.org/r/260881

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 27 2016, 7:00 PM
phuedx moved this task from Code Review to Done on the Reading-Web-Sprint-63-Ellip… board.Feb 1 2016, 11:06 AM
phuedx subscribed.

See 267654 for a demonstration.

phuedx closed this task as Resolved.Feb 1 2016, 11:06 AM
zeljkofilipin closed subtask T94157: Fix MultimediaViewer scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily as Resolved.Feb 26 2016, 10:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits