Maniphest T113813

Banner history: encode all hide reasons
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	awight
	Sep 25 2015, 10:24 PM

Tags

Referenced Files

None

Subscribers

Description

We need to deal with old hide cookies that didn't include the integer value of the hide reason enum, and onwiki scripts that use raw string hide reasons. The easiest solution is probably to create a reference table of all known hide reasons, in ext.centralNotice.display.state.js, and translate raw strings into Reason objects to be included in the banner history log.

Details

	Subject	Repo	Branch	Lines +/-
	Add more banner hide reasons	mediawiki/extensions/CentralNotice	master	+4 -1
	Enum for banner hide reasons	mediawiki/extensions/CentralNotice	wmf_deploy	+35 -33
	Enum for banner hide reasons	mediawiki/extensions/CentralNotice	master	+35 -33

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T112923 [EPIC] Banner history post launch
		Resolved		awight	T113813 Banner history: encode all hide reasons

Event Timeline

awight created this task.Sep 25 2015, 10:24 PM

awight claimed this task.

awight raised the priority of this task from to Needs Triage.

awight updated the task description. (Show Details)

awight added a project: Fundraising-Backlog.

awight added a project: MediaWiki-extensions-CentralNotice.

awight set Security to None.

awight added subscribers: • DStrine, Aklapper, awight.

awight updated the task description. (Show Details)Sep 25 2015, 10:27 PM

awight added a project: Fundraising Sprint Tom Waits.Sep 28 2015, 6:18 PM

awight moved this task from Backlog to Doing on the Fundraising Sprint Tom Waits board.

• DStrine moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Sep 28 2015, 8:00 PM

Change 241753 had a related patch set uploaded (by Awight):
WIP enum for banner hide reasons

https://gerrit.wikimedia.org/r/241753

gerritbot added a project: Patch-For-Review.Sep 28 2015, 8:02 PM

awight moved this task from Doing to Review on the Fundraising Sprint Tom Waits board.Sep 28 2015, 9:32 PM

awight edited a custom field.Sep 28 2015, 10:23 PM

awight moved this task from Review to Pending Deployment on the Fundraising Sprint Tom Waits board.

Change 241938 had a related patch set uploaded (by Awight):
Add more banner hide reasons

https://gerrit.wikimedia.org/r/241938

Change 241753 merged by jenkins-bot:
Enum for banner hide reasons

https://gerrit.wikimedia.org/r/241753

awight mentioned this in rECNOf76d1883fd04: Enum for banner hide reasons.Sep 28 2015, 10:31 PM

awight mentioned this in rMEXT29e9899d3b6e: Updated mediawiki/extensions Project: mediawiki/extensions/CentralNotice….

Change 241948 had a related patch set uploaded (by AndyRussG):
Enum for banner hide reasons

https://gerrit.wikimedia.org/r/241948

Change 241948 merged by Awight:
Enum for banner hide reasons

https://gerrit.wikimedia.org/r/241948

awight mentioned this in rMW9b851cf33b04: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….Sep 28 2015, 10:41 PM

awight mentioned this in rMW02e82bebaf4d: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….

awight mentioned this in rMW888e908d19af: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….

awight mentioned this in rMWc255a4857fb7: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….

AndyRussG mentioned this in rECNO04122d676331: Enum for banner hide reasons.Sep 28 2015, 10:42 PM

AndyRussG closed this task as Resolved.Sep 29 2015, 1:27 AM

AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Tom Waits board.

Ping: https://gerrit.wikimedia.org/r/#/c/241938/

Reopening to highlight remaining patch.

• DStrine added a project: Fundraising Sprint UB40.Sep 30 2015, 10:59 PM

awight moved this task from Backlog to Review on the Fundraising Sprint UB40 board.Sep 30 2015, 11:21 PM

• DStrine moved this task from Closed Sprint Work Q1 1516 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Oct 5 2015, 5:30 PM

awight moved this task from Review to Pending Deployment on the Fundraising Sprint UB40 board.Oct 5 2015, 8:06 PM

Change 241938 merged by jenkins-bot:
Add more banner hide reasons

https://gerrit.wikimedia.org/r/241938

Diffusion mentioned this in rMEXT9ebf063036f0: Updated mediawiki/extensions Project: mediawiki/extensions/CentralNotice….Oct 5 2015, 9:37 PM

awight mentioned this in rECNO097625d66673: Add more banner hide reasons.Oct 5 2015, 9:37 PM

awight moved this task from Pending Deployment to Done on the Fundraising Sprint UB40 board.Oct 14 2015, 8:13 PM

awight closed this task as Resolved.Oct 14 2015, 10:07 PM

• DStrine added a project: OKR-Work.Oct 20 2015, 8:46 PM

• DStrine added a project: Fundraising Sprint William Shatner.Oct 28 2015, 10:58 PM

• DStrine removed a project: Fundraising Sprint William Shatner.Oct 28 2015, 11:00 PM

• mmodell removed a subscriber: awight.Jun 22 2017, 9:37 PM

• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:45 PM