Page MenuHomePhabricator

VisualEditor: Link editor does not always open in Firefox with one click
Closed, ResolvedPublic0 Estimated Story Points

Description

How to reproduce:

  1. go to some page where are links on the page and open it in VE mode
  2. highlight some part of or the whole paragraph including a link or links.
  3. click outside of the highlighted text (so it goes unhighlighted)
  4. click some link that was inside of that highlighted text

And after this you should see that one click is not enough to open the link editor.
I tried with Microsoft Edge also, and it worked there.

Originally reported on fiwiki by user ComradeUranium.

The problem also exists sometimes without highlighting any text. For example when I opened https://fi.wikipedia.org/w/index.php?title=Nathan_Lieuwen&veaction=edit I had to click a random link on the article over 10 times before than the link editor opened.

Event Timeline

Stryn raised the priority of this task from to Needs Triage.
Stryn updated the task description. (Show Details)
Stryn subscribed.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

I can't reproduce the bug as described, but if I skip step 3 (i.e. select across a link, then click directly inside it) I get no link context menu until I move the cursor again.

The bug I described above was introduced with link cartouches in https://gerrit.wikimedia.org/r/#/c/217257/ according to bisect. Pinging @dchan.

Deskana claimed this task.
Deskana changed the point value for this task from 8 to 0.
Deskana subscribed.

All of these problems appear to have been fixed at some point.