Page MenuHomePhabricator

css bugs in modern skin with the latest echo spilt notifications.
Closed, ResolvedPublic

Description

Wikipedia:Village pump (technical)#WP:Notifications in Modern skin

All links are in lower case
Hover over is white type on a white background.

Both are seemingly addressed in mw.echo.ui.NotificationOptionWidget.modern.less and mw.echo.ui.NotificationBadgeWidget.modern.less but being overridden.

.mw-echo-ui-notificationOptionWidget {
	#p-personal & a,
	#p-personal & a.new {
		// In modern, the hover color is white, which is unhelpful.
		color: #666666;
		text-decoration: none;
	}

}
.mw-echo-ui-notificationBadgeButtonPopupWidget {
	font-variant: normal;
	text-transform: none;
	font-weight: normal;
	// Badge
	> .oo-ui-buttonElement-button {
		border-radius: none;
	}
}

Event Timeline

NQ raised the priority of this task from to Needs Triage.
NQ updated the task description. (Show Details)
NQ added projects: Notifications, Modern.
NQ added subscribers: NQ, Legoktm, Quiddity.

Change 242631 had a related patch set uploaded (by Legoktm):
Also override Modern's :hover styles

https://gerrit.wikimedia.org/r/242631

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 242631 merged by jenkins-bot:
Also override Modern's :hover styles

https://gerrit.wikimedia.org/r/242631

Catrope triaged this task as High priority.
Catrope set Security to None.
Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.

Change 242943 had a related patch set uploaded (by Catrope):
Fix lowercasing and bolding of text in popups in Modern skin

https://gerrit.wikimedia.org/r/242943

Change 242943 merged by jenkins-bot:
Fix lowercasing and bolding of text in popups in Modern skin

https://gerrit.wikimedia.org/r/242943

Etonkovidova subscribed.

All links are in lower case

Fixed - checked in betalabs.

Hover over is white type on a white background.

Still needs to be fixed.

Change 244371 had a related patch set uploaded (by Mooeypoo):
Override footer buttons hover color in Modern

https://gerrit.wikimedia.org/r/244371

Change 244371 merged by jenkins-bot:
Override footer buttons hover color in Modern

https://gerrit.wikimedia.org/r/244371

Catrope subscribed.