Besides fixing the client, we need to update the mw-vagrant role to setup restbase as well for local testing and labs use or change the defaults to just hit RESTBase for enwiki.
Description
Description
Details
Details
Revisions and Commits
Revisions and Commits
| Restricted Differential Revision |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | bd808 | T114186 Fix ParsoidClient to talk to RESTBase instead of Parsoid | |||
| Duplicate | None | T144031 Parsoid broken on iegreview.wikimedia.org |
Event Timeline
Comment Actions
<subbu> does ieg use parsoid somewhere? <bd808> subbu: yeah. it uses it to sanitize arbitrary input made by admins in the management console <subbu> i see ... do you have a repo url? if internal deploy, can switch it to use the internal name. <bd808> subbu: this is the current client -- https://github.com/wikimedia/wikimedia-slimapp/blob/master/src/ParsoidClient.php <bd808> subbu: which is a mirror of https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/slimapp <bd808> we could probably just change the prod config to point directly at a parsoid server <bd808> if it breaks it won't be the end of the world either <subbu> yes .. pointing it to parsoidcache.svc.eqiad.wmnet should work if it is an internal wmf install. <bd808> yeah. it's running in a ganetti vm in prod these days I think
Comment Actions
Change 267140 had a related patch set uploaded (by Subramanya Sastry):
T114186: Use internal LVS name for Parsoid service
Comment Actions
Change 267140 merged by jenkins-bot:
T114186: Use internal LVS name for Parsoid service
Comment Actions
Change 267269 had a related patch set uploaded (by Jforrester):
Point iegreview to internal parsoid url
Comment Actions
I think the short term fix of pointing to the internal LB for Parsoid rather than the old Varnish entry point has been taken care of now. The original goal of this ticket still remains however which is to switch from talking to Parsoid to talking to RESTBase.
Comment Actions
Change 307653 had a related patch set uploaded (by BryanDavis):
Update ParsoidClient to talk to RESTBase
Comment Actions
Change 307781 had a related patch set uploaded (by BryanDavis):
iegreview: Switch from Parsoid to RESTBase
Comment Actions
reviewed, merged, ran puppet on krypton.
deleted files in /var/cache/iegreview/
09:32 < mutante> !log iegreview switched from parsoid to RESTBase
09:33 < bd808> mutante: mostly fixed! One more thing while you are on krypton: delete all the files in /var/cache/iegreview please
09:33 < bd808> things that weren't cached are showing fine now, but we cached some broken stuff
09:33 < mutante> bd808: there are files ending in .parsoid and files ending in .restbase, ALL ALL or just .parsoid
09:34 < bd808> all all
09:34 < bd808> the parsoid ones won't get used anymore
09:34 < bd808> and some of the .restbase are junk
09:34 < Niharika> Awesome.
09:34 < Niharika> Works now.
09:38 < bd808> !log mutante updated puppet role and cleared cache for iegreview (T114186)