Page MenuHomePhabricator
Create Task
Maniphest T114448

Investigate the uses of the old editor system in Flow, and clean up the uses in handlebars
Closed, ResolvedPublic
Actions

Description

The old editor system is still being used in some edge cases. We need to:

  • Check whether there are any more uses,
  • Check whether the cases we know about can be fixed to use the new editor without much hassle
  • Clean up the references to the old editor in Handlebars

The currently known cases:

  • Clicking "undo" from the history page
  • Opening "edit reply" in a new window (presenting nojs view with javascript enabled)

Details

SubjectRepoBranchLines +/-
Use the new editor when undoing editsmediawiki/extensions/Flowmaster+84 -0
Use the new editor when editing topic summary in a new windowmediawiki/extensions/Flowmaster+39 -13
Replace old editor with new in no-js view with jsmediawiki/extensions/Flowmaster+46 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mooeypoo created this task.Oct 1 2015, 10:42 PM
Mooeypoo claimed this task.
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Mooeypoo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 10:42 PM
Mooeypoo moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.Oct 2 2015, 4:44 PM
gerritbot subscribed.Oct 5 2015, 10:56 PM

Change 243825 had a related patch set uploaded (by Mooeypoo):
Replace old editor with new in no-js view with js

https://gerrit.wikimedia.org/r/243825

gerritbot added a project: Patch-For-Review.Oct 5 2015, 10:56 PM
gerritbot added a comment.Oct 7 2015, 10:50 PM

Change 244369 had a related patch set uploaded (by Mooeypoo):
Use the new editor when undoing edits

https://gerrit.wikimedia.org/r/244369

Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 7 2015, 10:50 PM
Catrope subscribed.Oct 8 2015, 6:32 PM

The "edit topic summary" no-js view with JS enabled still uses the old system.

Catrope moved this task from Needs Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Oct 8 2015, 6:32 PM
gerritbot added a comment.Oct 8 2015, 6:36 PM

Change 243825 merged by jenkins-bot:
Replace old editor with new in no-js view with js

https://gerrit.wikimedia.org/r/243825

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 8 2015, 7:00 PM
gerritbot added a comment.Oct 9 2015, 6:26 AM

Change 244369 merged by jenkins-bot:
Use the new editor when undoing edits

https://gerrit.wikimedia.org/r/244369

gerritbot added a comment.Oct 12 2015, 7:29 PM

Change 245579 had a related patch set uploaded (by Mooeypoo):
Use the new editor when editing topic summary in a new window

https://gerrit.wikimedia.org/r/245579

Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 12 2015, 7:29 PM
gerritbot added a comment.Oct 13 2015, 1:00 AM

Change 245579 merged by jenkins-bot:
Use the new editor when editing topic summary in a new window

https://gerrit.wikimedia.org/r/245579

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 13 2015, 1:06 AM
Etonkovidova subscribed.Oct 14 2015, 9:41 PM

Clicking "undo" from the history page

Blocking issue: T115525 'undo' for Board description edits is not functioning

Etonkovidova added a subtask: T115525: [Regression wmf3] 'undo' for Board description edits is not functioning.Oct 14 2015, 9:41 PM
Etonkovidova mentioned this in T116085: History: 'undo' for topic summary still uses the old editor system (has the old-style icon).Oct 20 2015, 9:02 PM
Etonkovidova added a comment.Oct 20 2015, 9:09 PM

Summary:

Clicking "undo" from the history page

  • 'undo' uses the correct (new-style) wikitext icon for undo Comment and Board description

Blocking issue: T115525 'undo' for Board description edits is not functioning

  • Fixed/Verified

Opening "edit reply" in a new window (presenting nojs view with javascript enabled)

  • Checked.

T116085 "History: 'undo' for topic summary still has the old-style icon"

  • Filed.
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 20 2015, 9:09 PM
• Mattflaschen-WMF added a parent task: T117291: Remove old editor system.Oct 30 2015, 9:59 PM
Catrope closed subtask T115525: [Regression wmf3] 'undo' for Board description edits is not functioning as Resolved.Nov 22 2015, 10:54 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 22 2015, 10:54 PM
Catrope closed this task as Resolved.Nov 22 2015, 10:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits