Page MenuHomePhabricator
Create Task
Maniphest T114945

The drop down for categories in Upload image dialog opens too slowly, even sometimes after moving to the next field
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

1.Go to Media Settings>Upload
2.Select an image and upload
3.On the Details panel put your cursor on Categories field and type a letter
4.Then move to the next field

Observe that, the drop down for categories took so long that at first its hard to realize that there will be adrop dwon expanding here, It opened after I moved to the next field

Screen capture attached

too slow.mov7 MBDownload

Details

SubjectRepoBranchLines +/-
mw.widgets.CategorySelector: Indicate pending requests and abort useless onesmediawiki/coremaster+34 -8
OOjs UI: Backport aadaa8a1, 9aba218amediawiki/coremaster+20 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Oct 7 2015, 8:07 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2015, 8:07 PM
matmarex added a project: Multimedia.Oct 8 2015, 12:37 AM
matmarex subscribed.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 8 2015, 12:37 AM
matmarex claimed this task.Oct 9 2015, 11:47 AM
  • We should use the "pending" style on the input field while we're querying.
  • We should abort all queries when losing focus.
matmarex triaged this task as High priority.Oct 9 2015, 11:48 AM
gerritbot subscribed.Oct 9 2015, 1:59 PM

Change 244680 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.CategorySelector: Indicate pending requests and abort useless ones

https://gerrit.wikimedia.org/r/244680

gerritbot added a project: Patch-For-Review.Oct 9 2015, 1:59 PM
Jdforrester-WMF set Security to None.Oct 10 2015, 2:58 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
• Prtksxna moved this task from Untriaged to Done on the Multimedia board.Oct 12 2015, 10:52 AM
gerritbot added a comment.Oct 12 2015, 11:03 AM

Change 244680 merged by jenkins-bot:
mw.widgets.CategorySelector: Indicate pending requests and abort useless ones

https://gerrit.wikimedia.org/r/244680

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), MW-1.27-release-notes.Oct 12 2015, 12:00 PM
gerritbot added a comment.Oct 13 2015, 12:25 PM

Change 245867 had a related patch set uploaded (by Bartosz Dziewoński):
OOjs UI: Backport aadaa8a1, 9aba218a

https://gerrit.wikimedia.org/r/245867

gerritbot added a comment.Oct 13 2015, 2:27 PM

Change 245867 merged by jenkins-bot:
OOjs UI: Backport aadaa8a1, 9aba218a

https://gerrit.wikimedia.org/r/245867

Jdforrester-WMF closed this task as Resolved.Oct 13 2015, 2:50 PM
Jdforrester-WMF subscribed.
Ryasmeen added a project: Verified.Oct 13 2015, 7:37 PM
matmarex edited projects, added MW-1.26-release; removed MW-1.27-release-notes.Oct 16 2015, 6:42 PM

Patches cherry-picked to REL1_26 in 03e6ac38bf51456d9035b58040422358c41939f7.

Ryasmeen added a project: Verified-in-Phase0.Oct 20 2015, 9:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL