Page MenuHomePhabricator

Don't allow non-existent wikis in server configuration files
Closed, ResolvedPublic


In a wrong wiki name was added to InitialiseSettings.php - "nbwiki" instead of "nowiki".

It would be useful to catch this before it gets deployed using some kind of a test.

Event Timeline

Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added a subscriber: Amire80.
hashar added a subscriber: hashar.

A test has been introduced recently that loads InitialiseSettings.php. So one can no easily write a test that verify that keys of each of our settings are valid dblist filename | wiki database | 'default'.

Change 467448 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] [tests] Ensure only existing wikis are referenced from IS.php

Change 467448 merged by jenkins-bot:
[operations/mediawiki-config@master] [tests] Ensure only existing wikis are referenced from IS.php

It seems that got fixed by adding tests.