Page MenuHomePhabricator
Create Task
Maniphest T115138

Don't allow non-existent wikis in server configuration files
Closed, ResolvedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/#/c/244142/ a wrong wiki name was added to InitialiseSettings.php - "nbwiki" instead of "nowiki".

It would be useful to catch this before it gets deployed using some kind of a test.

Details

SubjectRepoBranchLines +/-
[tests] Ensure only existing wikis are referenced from IS.phpoperations/mediawiki-configmaster+30 -0
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Oct 9 2015, 7:28 PM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: Deployments, Continuous-Integration-Infrastructure, Release-Engineering-Team.
Amire80 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2015, 7:28 PM
greg edited projects, added Continuous-Integration-Config, MediaWiki-Configuration; removed Continuous-Integration-Infrastructure, Deployments.Oct 9 2015, 7:34 PM
greg set Security to None.
Krenair subscribed.Oct 9 2015, 8:05 PM
revi subscribed.Oct 10 2015, 9:38 AM
hashar removed a project: Continuous-Integration-Config.Oct 10 2015, 6:00 PM
hashar subscribed.

A test has been introduced recently that loads InitialiseSettings.php. So one can no easily write a test that verify that keys of each of our settings are valid dblist filename | wiki database | 'default'.

greg edited projects, added MediaWiki-Core-Tests, Release-Engineering-Team (Backlog); removed Release-Engineering-Team.May 20 2017, 12:30 PM
Krinkle edited projects, added Wikimedia-Site-requests; removed MediaWiki-Core-Tests, MediaWiki-Configuration.Jul 7 2017, 5:19 AM
Urbanecm moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.Aug 5 2017, 12:07 PM
Restricted Application added a subscriber: Danmichaelo. · View Herald TranscriptAug 5 2017, 12:07 PM
Urbanecm merged a task: T207074: Ensure only existing wikis are referenced from IS.php.Nov 6 2018, 7:03 PM
Urbanecm added subscribers: Urbanecm, gerritbot.
Restricted Application added a subscriber: jeblad. · View Herald TranscriptNov 6 2018, 7:03 PM
gerritbot added a comment.Nov 6 2018, 7:04 PM

Change 467448 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] [tests] Ensure only existing wikis are referenced from IS.php

https://gerrit.wikimedia.org/r/467448

gerritbot added a project: Patch-For-Review.Nov 6 2018, 7:04 PM
Urbanecm claimed this task.Nov 6 2018, 7:04 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptNov 6 2018, 7:04 PM
Urbanecm moved this task from Backlog to Waiting on review (config) on the User-Urbanecm board.Nov 15 2018, 7:05 AM
Urbanecm added a comment.Dec 3 2018, 10:21 AM

Anybody to review this patch?

gerritbot added a comment.Dec 9 2018, 6:04 PM

Change 467448 merged by jenkins-bot:
[operations/mediawiki-config@master] [tests] Ensure only existing wikis are referenced from IS.php

https://gerrit.wikimedia.org/r/467448

hashar closed this task as Resolved.Dec 12 2018, 8:36 AM

It seems that got fixed by adding tests.

Urbanecm added a comment.Dec 12 2018, 9:47 AM

Indeed, thanks for resolving.

Urbanecm moved this task from Waiting on review (config) to Waiting on review on the User-Urbanecm board.Apr 5 2019, 7:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits