Page MenuHomePhabricator

[Regression 2.0.131-alpha-2015-10-20] Attempting to enter search criteria produces 'The server could not complete the request'
Closed, ResolvedPublic

Description

Description

'The server could not complete the request' is displayed when attempting to delete search criteria with system keyboard 'delete' key ('x')

Steps to reproduce

  1. Start typing some search criteria in the Search box - e.g. test. Immediately multiple instances of letters or word 'test' are added
  2. Attempt to delete it by hitting 'x' on a system keyboard
  3. In the Search box, the entered text length keeps increasing in length

Expected results

The entered search criteria should be corrected by hitting 'x' icon on the keyboard

Actual results

The search criteria is not corrected - it multiplies to the point to produce 'The server could not complete the request'

Screenshot_2015-10-20-14-55-16.png (1×1 px, 118 KB)

Environments observed

App version: 2.0.131-alpha-2015-10-20
Android OS versions: Nexus 5
Device model: Android 5.1.1

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova subscribed.
Dbrant triaged this task as Unbreak Now! priority.Oct 20 2015, 10:36 PM
Dbrant subscribed.

Change 247753 had a related patch set uploaded (by Niedzielski):
Fix character repeating in search box

https://gerrit.wikimedia.org/r/247753

Change 247753 merged by jenkins-bot:
Fix character repeating in search box

https://gerrit.wikimedia.org/r/247753

Ouch! Sorry about that, I have a different keyboard installed and I didn't contemplate the possibility that this could break with the standard keyboard.

@DanReyLop, no sweat!! That whole InputFilter API is _awful_ because it's difficult to avoid side effects. Additionally, the documentation and examples available are minimal, and much of the AOSP text classes have functions that are miles long. For a while I was wondering if the issue was just some Samsung keyboard weirdness. Nope, just a bad API.

Verified the fix on my testing devices.

Change 249392 had a related patch set uploaded (by Subramanya Sastry):
T116091: Add api/server.js as a symlink to bin/server.js

https://gerrit.wikimedia.org/r/249392

Change 249392 merged by jenkins-bot:
T116091: Add api/server.js as a symlink to bin/server.js

https://gerrit.wikimedia.org/r/249392

Change 249426 had a related patch set uploaded (by Mobrovac):
Parsoid: let the service use the right config

https://gerrit.wikimedia.org/r/249426

Change 249426 merged by jenkins-bot:
Parsoid: let the service use the right config

https://gerrit.wikimedia.org/r/249426