Page MenuHomePhabricator

default lock file for scap3 should be repo-dependent
Closed, ResolvedPublic

Description

Since scap will be used to deploy mediawiki as well as other code, the default lock_file of /var/lock/scap is inadequate. The lock file should be changed so that by default a deploy of one repo won't interfere with the deploy of another.

Revisions and Commits

rMSCA Scap
Audited

Event Timeline

thcipriani raised the priority of this task from to Needs Triage.
thcipriani updated the task description. (Show Details)
thcipriani added projects: Scap, Deployments.
mmodell moved this task from To Triage to Next: Maintenance on the Deployments board.

I recently added a sync.flag (in D36), I think that could take the place of a lock file in /var/lock/scap. @thcipriani: Does that sound reasonable to you? The lock file could exist in the same location as the scap.cfg I suppose.

@mmodell, sounds like merging the two lock files is a reasonable approach. While both files have different semantics, both have the same effect of locking deployments.

Might also be neat if the sync.flag could contain a reason, like we have with puppet agent --disable

@thcipriani: I agree, I will add the 'reason' by writing a message to the lock file.

mmodell raised the priority of this task from Medium to High.Jan 20 2016, 5:34 PM
mmodell added a revision: Restricted Differential Revision.Jan 25 2016, 10:58 AM