Page MenuHomePhabricator
Create Task
Maniphest T116910

Unable to solve captcha on RTL languages due to bad element position
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Trizek-WMF
Oct 28 2015, 1:06 PM
Tags
Referenced Files
F2908104: Screen Shot 2015-11-02 at 9.51.10 AM.png
Nov 2 2015, 5:54 PM
F2885291: Screenshot - 28102015 - 13:59:57.png
Oct 28 2015, 1:06 PM
F2885292: Screenshot - 28102015 - 14:02:13.png
Oct 28 2015, 1:06 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
• Mattflaschen-WMF
Trizek-WMF
Tokens
"Like" token, awarded by Trizek-WMF.

Description

I've tried to add an external link on fa.wp, and the captcha block is inlined. Impossible to type the captcha code.

Screenshot - 28102015 - 13:59:57.png (383×745 px, 60 KB)

This seems to be specific to RTL languages: a test on a LTR wiki puts the captcha screen at the right place.

Screenshot - 28102015 - 14:02:13.png (496×1 px, 63 KB)

Details

SubjectRepoBranchLines +/-
Clean up captcha form and remove <link> to stylesheetmediawiki/extensions/Flowmaster+36 -11
Get captcha text in user languagemediawiki/extensions/Flowmaster+6 -6
Clean up captcha form and remove <link> to stylesheetmediawiki/extensions/Flowwmf/1.27.0-wmf.4+36 -11
Customize query in gerrit

Event Timeline

Trizek-WMF created this task.Oct 28 2015, 1:06 PM
Trizek-WMF raised the priority of this task from to Needs Triage.
Trizek-WMF updated the task description. (Show Details)
Trizek-WMF added a project: StructuredDiscussions.
Trizek-WMF subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 28 2015, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Mattflaschen-WMF triaged this task as Unbreak Now! priority.Oct 28 2015, 5:05 PM
• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
• Mattflaschen-WMF set Security to None.
• Mattflaschen-WMF subscribed.
Catrope assigned this task to Mooeypoo.Oct 29 2015, 5:41 PM
gerritbot subscribed.Oct 29 2015, 9:10 PM

Change 249882 had a related patch set uploaded (by Mooeypoo):
Clean up captcha form and remove <link> to stylesheet

https://gerrit.wikimedia.org/r/249882

gerritbot added a project: Patch-For-Review.Oct 29 2015, 9:10 PM
gerritbot added a comment.Oct 29 2015, 10:29 PM

Change 249882 merged by jenkins-bot:
Clean up captcha form and remove <link> to stylesheet

https://gerrit.wikimedia.org/r/249882

gerritbot added a comment.Oct 29 2015, 10:31 PM

Change 249910 had a related patch set uploaded (by Catrope):
Clean up captcha form and remove <link> to stylesheet

https://gerrit.wikimedia.org/r/249910

Catrope subscribed.Oct 29 2015, 10:54 PM
In T116910#1766752, @gerritbot wrote:

Change 249882 had a related patch set uploaded (by Mooeypoo):
Clean up captcha form and remove <link> to stylesheet

https://gerrit.wikimedia.org/r/249882

That fixes the immediate issue, so I've put that in the upcoming SWAT. However, it does break styles and scripts for CAPTCHAs completely, so we should come up with a proper fix that allows CAPTCHA implementations to add RL modules without that resulting in double-including a bunch of skin CSS.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 29 2015, 11:00 PM
gerritbot added a comment.Oct 29 2015, 11:10 PM

Change 249910 merged by jenkins-bot:
Clean up captcha form and remove <link> to stylesheet

https://gerrit.wikimedia.org/r/249910

gerritbot added a comment.Oct 29 2015, 11:39 PM

Change 249926 had a related patch set uploaded (by Mooeypoo):
Get captcha text in user language

https://gerrit.wikimedia.org/r/249926

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 30 2015, 12:00 AM
gerritbot added a comment.Oct 30 2015, 12:02 AM

Change 249926 merged by jenkins-bot:
Get captcha text in user language

https://gerrit.wikimedia.org/r/249926

Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 30 2015, 2:32 AM
Etonkovidova subscribed.Nov 2 2015, 5:54 PM

Checked in betalabs - translation corrections to CAPTCHA are done and the captcha can be resolved..

Screen Shot 2015-11-02 at 9.51.10 AM.png (491×784 px, 58 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Nov 2 2015, 5:54 PM
Trizek-WMF awarded a token.Nov 2 2015, 5:55 PM
Catrope closed this task as Resolved.Nov 13 2015, 7:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits