Page MenuHomePhabricator

On Safari the thanks confirmation is not hidden correctly
Closed, DeclinedPublic

Description

A user on de.wp reports a problem with the thanks confirmation on a history page or a diff view.

Steps done by the user:

  • Click thanks on an edit
  • Click "No" in the confirmation
  • The "thanks" is shown, but the confirmation sentence is still show, where you can click "no" again and so on

In german it shows like this

„dankenDankeschön für diese Bearbeitung senden (stets öffentlich)? Ja Nein“

The first "danken" is the normal link to start thanks the rest is the confirmation sentence.

The user is using a safari (no version information).
Another user has the problem on Safari 7.1.7.
A third user reports problems with an IE9

https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Werkstatt&oldid=147556178#Safari_und_Danken-Funktion
https://de.wikipedia.org/w/index.php?title=Wikipedia:Administratoren/Anfragen&oldid=146988190#.27danken.27_-Text

Event Timeline

Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I guess this is an issue with jquery.confirmable then?

Presumably, although I can't reproduce the issue in IE 9. There's no "slide out" animation, but everything else works as expected. (I don't have a Mac to test Safari.)

Tested English Wikipedia on OS X Mavericks with Safari 7.1.7, on Sauce Labs.

Can not reproduce. It hides properly after I click 'Nein'.

Mattflaschen-WMF renamed this task from On Safari and IE9 the thanks confirmation is not hide correctly to On Safari and IE9 the thanks confirmation is not hidden correctly.Nov 2 2015, 4:47 PM
Mattflaschen-WMF set Security to None.
Jdforrester-WMF changed the task status from Open to Stalled.Apr 6 2017, 11:07 PM
Jdforrester-WMF subscribed.

Moving to "Stalled" as it is waiting on reproduction steps.

Jdforrester-WMF renamed this task from On Safari and IE9 the thanks confirmation is not hidden correctly to On Safari the thanks confirmation is not hidden correctly.Apr 6 2017, 11:07 PM

Dropped IE references as IE9 no longer gets JavaScript.

@Umherirrender, have tested on Mac + Safari but cannot reproduce the issue as well.
Do you still reproduce it on your side?

Unfortunately closing this Phabricator task as nobody can reproduce. @Umherirrender: If this still happens and if you can find better steps to reproduce, please set the status of this task back to "Open" via the Add Action...Change Status dropdown. Thanks!