Steps to reproduce
Actual results
Expected results
Upstream task: https://secure.phabricator.com/T8170
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Allow viewing php files in raw format in browsers | operations/puppet | production | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • mmodell | T117621 Diffusion support for viewing the raw file in the browser | |||
| Resolved | • mmodell | T128009 Next Phabricator Upgrade | 2016-04-28 | |||
| Open | None | T149152 Diffusion 'view raw file' policy and behavior is unclear and inconsistent (PHP files displayed in browser; JS files offer downloading file) |
If you go to https://phabricator.wikimedia.org/F2912532 it wont allow you to view plain text it wants you to download the whole file.
How is your last comment about some random file attachment uploaded by some user in Phabricator related to the task description which is about browsing and viewing code files in a Diffusion repository?
Because it is about viewing raw files. I gave the link to a file that shows you have to download the raw file, you carn't view the raw file in plain text.
@Aklapper, because it is an example file from a repo. Please AGF. Go to any file listed on https://phabricator.wikimedia.org/diffusion/ETRA/, eg https://phabricator.wikimedia.org/diffusion/ETRA/browse/master/MessageChecks.php then click on "view raw" which takes you to https://phabricator.wikimedia.org/F2912605
Ah interesting.
So for example this does not happen with https://phabricator.wikimedia.org/diffusion/ETRA/browse/master/.jshintrc - I just tried the "wrong" files so far to reproduce.
@Paladox: That's why clear exact steps to reproduce are welcome, and not "Click on any file." as long as you have not tried all files...
For future reference please don't assume anything but provide absolutely clear and specific steps to reproduce. Thanks.
According to https://secure.phabricator.com/T8170 a workaround is to add the support to files.viewable-mime-types
So, I think the main issue here is related to Diffusion repo browsing, which is reasonable. I'm going to retitle/focus this for just that (which is then our tracking task for that upstream one Paladox just linked).
The patch I uploaded is temp as the upstream task describes to use it as a workaround. This task shoulden be closed when patch is merged. Since theres other files that are supported in raw format in gitblit but not yet here.
Change 251034 had a related patch set uploaded (by Paladox):
Allow viewing php files in raw format in browsers
@Paladox the change has been merged and applied on iridium. but i can't really confirm it as fixed yet, i still just get a download button. can you try?
@Dzahn it works on an iPhone 6 Plus haven't tested on a laptop but I presume it works if it doesn't do download on a iPhone. But you have to now click download which will show the content in browser instead of downloading it. I think once you press that raw button it should go to the raw file not make you go to the page where you have to click download too to view the file .
@Paladox ok, thanks for the clarification. i noticed the same (first goes to an extra page, then download button) but wasn't sure. afaict this is the best we can get right now.
Re opening since I tested on laptop and still asks you to download you carn't view it in browser.
We have applied the fix suggested by upstream but the bug has been reopened as not working.
it seems that 'text/x-php': 'text/x-php; charset=utf-8' doesn't work for desktops but works for mobiles.
Would setting it like 'text/x-php': 'text/plain; charset=utf-8' or not. How can we get it to work on desktop like it is on mobile.
@Paladox: If it does not work on desktop, please provide **exact** steps to reproduce.
I can try to describe the problem from my view (I can replicate it):
For example:
I hope this helps
Yes, i can confirm that. Clicking "view raw file" in diffusion does not actually show the raw file but takes you the the "F" phabricator page for it.
In even less words, this link says "view=raw":
https://phabricator.wikimedia.org/diffusion/ETRA/browse/master/TranslateTasks.php?view=raw
but redirects to https://phabricator.wikimedia.org/F3204274
I uploaded a patch that was merged and I tested it on my local install and worked but didn't on diffusion wikimedia. I think this may be a bug because if you use custom domains for files then it causes the problem but if you doint use a custom domain then you can view the file in browser.
Adding @mmodell since this seems to be a bug since it also happends upstream but that's probably because they haven't set it to what we set it. But you can view some files like .gitreview as raw files but php you carn't but what's strange is you can view it on your mobile browser ie iPhone safari but not on a Windows 10 PC. So looks like a bug.
6b9b0cc5b26a fixes this, at least in Firefox, however, it is not yet deployed to wmf/stable.