Page MenuHomePhabricator

Create an extremely bare-bones RL module, containing basic, simple styles for skins to consume
Closed, ResolvedPublic


content.css, elements.css & interface.css in resources/src/mediawiki.skinning/ are not always ideal:

[21:12:54] <Isarra> I've generally found I never want any of them because they all come with useless (and poorly-written) baggage.
[21:14:03] <Isarra> What I'm proposing, though, is barely even interface. Where those all have styles (borders, backgrounds, sizes, whatever), this is just really simple things like clears and noprints and make RTL actually work and anything else ANY skin, no matter the style, will need and use.

Furthermore shared.css and/or oldshared.css from resources/src/mediawiki.legacy/ are always available on most/all skins (?) and they contain some styles, such as the visualClear class definition, which should ideally be in this new RL module.

Event Timeline

ashley raised the priority of this task from to Needs Triage.
ashley updated the task description. (Show Details)
ashley added subscribers: ashley, Isarra, matmarex.

The idea here is this will be things that aren't even styles that stand out as styles - they're just little things to be used wherever.

We can start by deprecating mediawiki.legacy and replacing it, but I expect there will also be some definitions from content, elements, or interface that ought to be moved out as well down the line.

This task is not clear to me. Are you proposing that we clean up shared.css and make it non-legacy?

Yeah, looks like this is a subset of that. A module for... the less styley bits.

jhobs triaged this task as Medium priority.Nov 11 2015, 6:12 PM
jhobs set Security to None.
Jdlrobson lowered the priority of this task from Medium to Lowest.Dec 10 2015, 11:24 PM
Jdlrobson subscribed.

Change 546733 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule is configurable with different features

Change 546733 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Provide optional mediawiki.skinning styles

Jdlrobson claimed this task.

This is now provided. A skin should make use of the ResourceLoaderSkinModule class and define the set of features it wants to include.
We can create specific tasks for pulling out the remaining baggage, but that's for another task :)