Maniphest T119146

fix schema MobileWebSectionUsage
Closed, ResolvedPublic
Actions

Description

investigate/undo the persistence of the sessionid sent to EventLogging.
- https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.loggingSchemas/SchemaMobileWebSectionUsage.js#L32 which calls:
- https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.user/user.js#L33-L50
- which (as I read it) is using localStorage, which has no expiry / purge mechanism

fix the talk page for the schema below (the page doesn't exist at this time):
- https://meta.wikimedia.org/wiki/Schema:MobileWebSectionUsage
- It should contain something similar to this: https://meta.wikimedia.org/wiki/Schema_talk:MobileWebSearch

Details

	Subject	Repo	Branch	Lines +/-
	Remove previously stored session IDs	mediawiki/extensions/MobileFrontend	master	+14 -2
	getSessionId's value should only last for session duration	mediawiki/extensions/MobileFrontend	master	+2 -11

Customize query in gerrit

Related Objects

Mentioned In: T128931: investigate instrumentation of section opens/scrolls
T119153: QuickSurveys: Add sessionId to Schema:QuickSurveysResponses

Event Timeline

• kevinator created this task.Nov 19 2015, 11:36 PM

• kevinator assigned this task to • JKatzWMF.

• kevinator raised the priority of this task from to Needs Triage.

• kevinator updated the task description. (Show Details)

• kevinator added a project: Mobile.

• kevinator added subscribers: • kevinator, dr0ptp4kt, phuedx, ori.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 19 2015, 11:36 PM

• Tbayer subscribed.Nov 20 2015, 3:23 AM

• kevinator updated the task description. (Show Details)Nov 20 2015, 6:48 AM

• kevinator set Security to None.

• Tbayer mentioned this in T119153: QuickSurveys: Add sessionId to Schema:QuickSurveysResponses.Nov 20 2015, 7:58 AM

@Jdlrobson welcome back! I think this is something you should probably manage. @Jhernandez, I am going to throw this in sprint 62 tentatively, in case JR confirms it is an issue and we need to pull it ASAP

• JKatzWMF added a project: Reading-Web-Planning.Nov 26 2015, 12:29 AM

• JKatzWMF moved this task from To classify to 2016-17 Q1 on the Reading-Web-Planning board.

Change 255796 had a related patch set uploaded (by BryanDavis):
getSessionId's value should only last for session duration

https://gerrit.wikimedia.org/r/255796

gerritbot added a project: Patch-For-Review.Nov 28 2015, 6:24 AM

Updated talk page. Also added notes to https://www.mediawiki.org/wiki/Reading/Web/EventLogging_best_practices to prevent this happening in future.

Jdlrobson updated the task description. (Show Details)Nov 30 2015, 8:15 PM

Jdlrobson reassigned this task from Jdlrobson to bd808.Dec 1 2015, 1:01 AM

Jdlrobson added a project: Reading Web Sprint 61 - Cold Hard Cache.

Jdlrobson moved this task from Needs Analysis to -1 (Needs More Work) on the Reading Web Sprint 61 - Cold Hard Cache board.

Restricted Application added a project: User-bd808. · View Herald TranscriptDec 1 2015, 1:02 AM

Jdlrobson moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 2 2015, 1:38 AM

Change 255796 merged by jenkins-bot:
getSessionId's value should only last for session duration

https://gerrit.wikimedia.org/r/255796

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 2 2015, 2:00 AM

bd808 triaged this task as Medium priority.Dec 2 2015, 3:45 AM

bd808 moved this task from To Do to Done on the User-bd808 board.

phuedx updated the task description. (Show Details)Dec 7 2015, 10:28 AM

I've left a comment to the patch. I've also tested it on the beta cluster and as expected the localStorage sessionId is not being set and the cookie session ID expires once the user quits the browser.

Change 257296 had a related patch set uploaded (by Phuedx):
Remove previously stored session IDs

https://gerrit.wikimedia.org/r/257296

phuedx moved this task from Ready for Signoff to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 7 2015, 11:34 AM

• bmansurov moved this task from Code Review to Done on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 7 2015, 11:36 AM

Change 257296 merged by jenkins-bot:
Remove previously stored session IDs

https://gerrit.wikimedia.org/r/257296

phuedx closed this task as Resolved.Dec 7 2015, 2:44 PM

bd808 moved this task from Done to Archive on the User-bd808 board.Dec 10 2015, 5:08 PM

• Jhernandez unsubscribed.Dec 16 2015, 8:47 AM

• Tbayer mentioned this in T128931: investigate instrumentation of section opens/scrolls.May 10 2016, 11:24 PM