Page MenuHomePhabricator

The icon images for the "Inline" and "Block" buttons in the TemplateData editor don't appear
Closed, ResolvedPublic1 Story Points

Description

The recently-added "Inline" and "Block" buttons have icons in the English Wikipedia:

But they don't appear in the Hebrew Wikipedia:

Event Timeline

Amire80 created this task.Nov 23 2015, 7:25 AM
Amire80 updated the task description. (Show Details)
Amire80 raised the priority of this task from to Normal.
Amire80 added subscribers: Amire80, eranroz, Mooeypoo.
Restricted Application added a project: I18n. · View Herald TranscriptNov 23 2015, 7:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Actually, I don't see it in the Russian Wikipedia either, so maybe it's not an RTL bug:

Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Krenair renamed this task from The icon images for the "Inline" and "Block" buttons in the TemplateData don't appear in the Hebrew Wikipedia to The icon images for the "Inline" and "Block" buttons in the TemplateData editor don't appear.Jan 13 2016, 4:56 AM
Krenair edited a custom field.

Doesn't appear anywhere for me

Seems to be because the ext.templateData RL module does not get loaded.

Krenair claimed this task.Jan 13 2016, 5:06 AM

Change 263810 had a related patch set uploaded (by Alex Monk):
Make ext.templateDataGenerator.ui depend on ext.templateData

https://gerrit.wikimedia.org/r/263810

Krenair moved this task from Backlog to Doing on the TemplateData board.Jan 13 2016, 5:07 AM
matmarex closed this task as Resolved.Jan 13 2016, 5:42 PM
matmarex removed a project: Patch-For-Review.

Change 263810 merged by jenkins-bot:
Make ext.templateDataGenerator.ui depend on ext.templateData

https://gerrit.wikimedia.org/r/263810