Page MenuHomePhabricator
Create Task
Maniphest T119361

The icon images for the "Inline" and "Block" buttons in the TemplateData editor don't appear
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The recently-added "Inline" and "Block" buttons have icons in the English Wikipedia:

inline-block-en.png (733×1 px, 119 KB)

But they don't appear in the Hebrew Wikipedia:

inline-block-he.png (733×1 px, 74 KB)

Details

SubjectRepoBranchLines +/-
Make ext.templateDataGenerator.ui depend on ext.templateDatamediawiki/extensions/TemplateDatamaster+1 -0
Customize query in gerrit

Event Timeline

Amire80 created this task.Nov 23 2015, 7:25 AM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: RTL, TemplateData, VisualEditor.
Amire80 added subscribers: Amire80, eranroz, Mooeypoo.
Restricted Application added a project: I18n. · View Herald TranscriptNov 23 2015, 7:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 added a comment.Nov 23 2015, 8:10 AM

Actually, I don't see it in the Russian Wikipedia either, so maybe it's not an RTL bug:

inline-block-ru.png (733×1 px, 109 KB)

Jdforrester-WMF set Security to None.Nov 24 2015, 8:19 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.Jan 12 2016, 8:22 PM
Krenair removed projects: VisualEditor-MediaWiki, VisualEditor.Jan 13 2016, 4:53 AM
Krenair renamed this task from The icon images for the "Inline" and "Block" buttons in the TemplateData don't appear in the Hebrew Wikipedia to The icon images for the "Inline" and "Block" buttons in the TemplateData editor don't appear.Jan 13 2016, 4:56 AM
Krenair edited a custom field.
Krenair subscribed.Jan 13 2016, 4:59 AM

Doesn't appear anywhere for me

Krenair added a comment.Jan 13 2016, 5:03 AM

Seems to be because the ext.templateData RL module does not get loaded.

Krenair removed projects: I18n, RTL.Jan 13 2016, 5:03 AM
Krenair claimed this task.Jan 13 2016, 5:06 AM
gerritbot subscribed.Jan 13 2016, 5:06 AM

Change 263810 had a related patch set uploaded (by Alex Monk):
Make ext.templateDataGenerator.ui depend on ext.templateData

https://gerrit.wikimedia.org/r/263810

gerritbot added a project: Patch-For-Review.Jan 13 2016, 5:06 AM
Krenair moved this task from Backlog to Doing on the TemplateData board.Jan 13 2016, 5:07 AM
matmarex closed this task as Resolved.Jan 13 2016, 5:42 PM
matmarex removed a project: Patch-For-Review.
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.Jan 13 2016, 5:43 PM
gerritbot added a comment.Jan 13 2016, 5:43 PM

Change 263810 merged by jenkins-bot:
Make ext.templateDataGenerator.ui depend on ext.templateData

https://gerrit.wikimedia.org/r/263810

Jdforrester-WMF edited a custom field.Jan 13 2016, 5:43 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 13 2016, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits