Page MenuHomePhabricator

On transparency.wikimedia.org, add IDs to <h2>
Closed, ResolvedPublic

Description

It should be possible to link directly to the graphs titles on

As well as the h3 of

https://transparency.wikimedia.org/faq.html already has names in as so they can be linked directly (it would be nice that the linked section expanded automatically, though)

Event Timeline

Platonides raised the priority of this task from to Needs Triage.
Platonides updated the task description. (Show Details)

Surely you can make a patch for this

Where's the code for the microsites?

Aklapper renamed this task from [transparency] Add ids to h2 to On transparency.wikimedia.org, add IDs to <h2>.Dec 6 2015, 6:50 PM

https://transparency.wikimedia.org/faq.html already has names in as so they can be linked directly (it would be nice that the linked section expanded automatically, though)

Doesn't this happen for you already? Try clicking on this link https://transparency.wikimedia.org/faq.html#standards. Are there any errors on the console?

Occasionally I would get this error in the console:
Uncaught Error: Syntax error, unrecognized expression: a[name=standards.]

The change in functions would fix this.

Change 258689 had a related patch set uploaded (by Microchip08):
Add ID to link to graphs and headings

https://gerrit.wikimedia.org/r/258689

Change 258689 had a related patch set uploaded (by Prtksxna):
Add ID to link to graphs and headings

https://gerrit.wikimedia.org/r/258689

Change 258689 had a related patch set uploaded (by Prtksxna):
Add ID to link to graphs and headings

https://gerrit.wikimedia.org/r/258689

Change 258689 merged by Prtksxna:
Add ID to link to graphs and headings

https://gerrit.wikimedia.org/r/258689

Waiting for @Justin-Leung to submit a change with the updated build folder before marking this task as resolved.

Aklapper removed a project: Patch-For-Review.

removing Patch-For-Review (nothing left to review) and assignee as per last comment. (Feel free to reset assignee once you plan to work on this :) )

Prtksxna claimed this task.

I am sure the website has been buildta couple of times since that patch was merged.