Page MenuHomePhabricator

As a user viewing the POTD I would like to browse older pictures in the gallery
Closed, ResolvedPublic

Description

Gallery View

Given that I am viewing today's picture in the Gallery
When I swipe forward
Then I should see the previous commons picture of the day

Given that I have viewed all available pictures in the Gallery
When I swipe forward
Then I should continue to see the current picture

Given that I am viewing a previous day's picture in the Gallery
When I swipe back
Then I should see the subsequent days picture

Event Timeline

JMinor raised the priority of this task from to Medium.
JMinor updated the task description. (Show Details)

I had mentioned this earlier, but a perhaps simpler, more visually consistent alternative would be:

  • make POTD layout used same layout as other feed cards
  • add footer beneath the POTD card saying "Past pictures"
  • when tapped this footer would load a list which looks exactly like the saved pages list, but each card's title would be the date, the image would be the picture, the description would be the image description. newest POTD would appear at top with past POTD's in order beneath.
  • if the user taps a card only *then* we would load it in the gallery so it can be pinch/zoomed (this would also apply to the single POTD card in the feed)

Thoughts?
@Nirzar @KHammerstein @JMinor

Checked with 5.0.0.534 on iPad iOS 9.1

Please confirm that it's a desired behavior:

  1. When I am viewing POTD, and swipe back(swipe from the left edge of the screen), there is no previous POTD - the previous pictures appear with swipe forward.
  1. Only 16 POTD are presented in the Gallery. When all 16 are viewed, swipe forward does not work anymore; swipe back brings the previous, 15th picture. There is nothing special about viewing 7 pictures.

Thanks @Etonkovidova

  1. This is not as spec'd. I thought of Todays picture as the "last" picture, and reviewing older pictures as "going back". I need to use the feture for a couple days to determine if the implemented version makes sense, or we should stick to the spec. I will either resolve or move the ticket back.
  1. There is nothing special about 7 pictures, It was just to capture a weeks worth of POTD and avoid slow loading times or being a bandwidth hog. As long as we are not downloading a large batch of images, I am fine with 15 or 16. @BGerstle-WMF is their a practical limit we need to enforce? Or does Commons have limit.

Reassign to me, to decide if we update the spec or the behavior.

JMinor updated the task description. (Show Details)

Updated spec to reflect that 7 is not a hard requirement, and that swiping should work as implemented.

Let me know what you all want as far as which direction should be back/forward in time. I'll make two points that might sway you and answer @JMinor's question at the same time:

  • There is no practical limit on how many images we get. They're all fetched individually for the specified date you're trying to view
  • However, adding later images to the "end" of the list is much easier technically. Add'l logic would be necessary to prepend as we add more dates and track the user's position