Page MenuHomePhabricator

Gather's extension.json does not validate against the schema
Closed, ResolvedPublic

Description

$ mediawiki/vendor/bin/validate-json mediawiki/extensions/Gather/extension.json mediawiki/docs/extension.schema.json
JSON does not validate. Violations:
[ResourceModules.ext.gather.collection.editor] The property - @doc - is not defined and the definition does not allow additional properties
[ResourceModules.ext.gather.collection.editor] The property - targets - is not defined and the definition does not allow additional properties
[ResourceModules.ext.gather.collection.editor] The property - dependencies - is not defined and the definition does not allow additional properties
[ResourceModules.ext.gather.collection.editor] The property - messages - is not defined and the definition does not allow additional properties
[ResourceModules.ext.gather.collection.editor] The property - templates - is not defined and the definition does not allow additional properties
[ResourceModules.ext.gather.collection.editor] The property - scripts - is not defined and the definition does not allow additional properties
[ResourceModules.ext.gather.collection.editor] The property - styles - is not defined and the definition does not allow additional properties
[class] The property class is required
[ResourceModules.ext.gather.collection.editor] Failed to match at least one schema
extensions/Gather/extension.json
		"ext.gather.collection.editor": {
			"targets": [
				"mobile",
				"desktop"
			],
			"@doc": "FIXME: ext.gather.styles gets loaded twice. See https://phabricator.wikimedia.org/T87871",
...

@doc is not a valid parameter to ResourceLoaderFileModule.

Event Timeline

Legoktm created this task.Dec 5 2015, 5:10 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a project: Gather.
Legoktm added a subscriber: Legoktm.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 5 2015, 5:10 AM
Legoktm triaged this task as Low priority.Dec 5 2015, 5:11 AM

Change 273753 had a related patch set uploaded (by Legoktm):
Pass extension.json schema validation

https://gerrit.wikimedia.org/r/273753

Patch is -1ed

Change 273753 merged by jenkins-bot:
Pass extension.json schema validation

https://gerrit.wikimedia.org/r/273753

Jdforrester-WMF closed this task as Resolved.Mar 14 2016, 7:42 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF reassigned this task from Jdforrester-WMF to Legoktm.
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.