Page MenuHomePhabricator

In Firefox, backspace before inserting a Citoid citation triggers browser back naviation
Open, Needs TriagePublic

Description

Steps to reproduce

  1. In Firefox, open a page in VisualEditor.
  2. Use the Citoid service to generate a citation.
  3. Before clicking "insert" in the citation context item, hit backspace.
  4. Rather than aborting the Citoid process (i.e. discarding the generated citation), the backspace causes a dialog to appear asking whether you want to leave the page with unsaved changes.

Event Timeline

Whatamidoing-WMF raised the priority of this task from to Needs Triage.
Whatamidoing-WMF updated the task description. (Show Details)

None of your changes will have been lost; if there are changes, backspace will trigger an "are you sure?" question. All you'll have lost is cursor position and the what you wrote into the auto-cite box (which is probably still in your paste buffer), right?

No, it doesn't. I agree that it should trigger an "Are you sure?" dialog box, but it doesn't.

The reason I hit the backspace key is because the auto-cite box was filled with useless information. I had the URL in my paste buffer. I did not, unfortunately, have the entire rest of the unsaved changes to the article in my paste buffer. I lost a non-trivial amount of work.

I cannot reproduce in firefox 42 ubuntu, at my enwiki user sandbox, no matter what i try. I tried a few variations, as well as the exact sequence described, and either the browser-warning or VE discard edit warning will always appear, or just the character/element before the cursor is deleted. :-/

Can you explain why your browser didn't show "Are you sure?"? Does it fail to do this in other contexts? That's a UBN; this is a WONTFIX.

Jdforrester-WMF changed the task status from Open to Stalled.Dec 15 2015, 8:16 PM
Jdforrester-WMF set Security to None.
nshahquinn changed the task status from Stalled to Open.Sep 10 2019, 8:27 PM
nshahquinn subscribed.

I cannot reproduce in firefox 42 ubuntu, at my enwiki user sandbox, no matter what i try. I tried a few variations, as well as the exact sequence described, and either the browser-warning or VE discard edit warning will always appear, or just the character/element before the cursor is deleted. :-/

Same here. In Firefox 70.0b5 on macOS 10.14.6, I can reproduce that backspace over a generated-but-not-inserted citation triggers the discard-edit warning (which is undesirable behavior but not high-priority problem), but I can't reproduce anything that bypasses the warning.

I'll amend the title and description to reflect that.

nshahquinn renamed this task from Backspace before inserting a citation loses all changes (due to browser behavior) to In Firefox, backspace before inserting a Citoid citation triggers browser back naviation.Sep 10 2019, 8:31 PM
nshahquinn updated the task description. (Show Details)