Page MenuHomePhabricator
Create Task
Maniphest T121875

File uploads are not properly tagged (only the log entry, not the revision)
Closed, ResolvedPublic
Actions

Description

OAuth file uploads are not properly tagged. The tag only applies to the recent changes entry (and the associated upload log entry), but not the file page revision.

Related Objects
Search...

Event Timeline

matmarex created this task.Dec 18 2015, 4:45 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: MediaWiki-Uploading, MediaWiki-extensions-OAuth.
matmarex subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptDec 18 2015, 4:45 PM
Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald Transcript
matmarex added a subtask: T121874: Tagging file uploads with change tags is difficult bordering on impossible.Dec 18 2015, 4:45 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptDec 18 2015, 4:45 PM
matmarex added a parent task: T121864: Allow various uploading tools on Commons to mark their uploads with change tags.Dec 18 2015, 4:49 PM
MarkTraceur triaged this task as Low priority.Dec 21 2015, 9:19 PM
MarkTraceur subscribed.
matmarex claimed this task.Dec 21 2015, 10:15 PM

I think this will be magically fixed by https://gerrit.wikimedia.org/r/#/c/211656/.

matmarex edited subtasks, added: T122089: Log entries and associated page revisions are not actually associated in the database; removed: T121874: Tagging file uploads with change tags is difficult bordering on impossible.Dec 21 2015, 10:15 PM
matmarex added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 7 2016, 12:34 AM

That was merged, and this should be magically fixed. I'll wait for the deployment to happen to verify and close it then.

matmarex closed subtask T122089: Log entries and associated page revisions are not actually associated in the database as Resolved.Jan 7 2016, 2:34 AM
matmarex closed this task as Resolved.Jan 18 2016, 5:17 PM

Indeed it is!

matmarex added a project: AbuseFilter.Jan 19 2016, 8:36 PM

The same issue affected AbuseFilter tags and is fixed there too.

matmarex renamed this task from OAuth file uploads are not properly tagged to File uploads are not properly tagged (only the log entry, not the revision).Jan 19 2016, 8:36 PM
matmarex reassigned this task from matmarex to Cenarium.
matmarex set Security to None.
Cenarium added a comment.Jan 19 2016, 9:21 PM
In T121875#1941453, @matmarex wrote:

Indeed it is!

Great!

matmarex mentioned this in T124214: Allow filtering based on tag on Special:NewFiles.Jan 20 2016, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL