Page MenuHomePhabricator
Create Task
Maniphest T121954

Add secondary link to Flow board for flow-thanks notifications
Closed, ResolvedPublic
Actions

Description

Thanks notifications for Flow comments should have a secondary link pointing to the talk page / Flow board.

Details

SubjectRepoBranchLines +/-
Add secondary link to Flow board for flow-thanks notificationsmediawiki/extensions/Thanksmaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Dec 19 2015, 12:53 AM
Catrope claimed this task.
Catrope raised the priority of this task from to Medium.
Catrope updated the task description. (Show Details)
Catrope added projects: Thanks, Collaboration-Team-Archive-2015-2016.
Catrope subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2015, 12:53 AM
gerritbot subscribed.Dec 19 2015, 12:53 AM

Change 260168 had a related patch set uploaded (by Catrope):
Add secondary link to Flow board for flow-thanks notifications

https://gerrit.wikimedia.org/r/260168

gerritbot added a project: Patch-For-Review.Dec 19 2015, 12:53 AM
Catrope added a comment.Dec 19 2015, 12:54 AM
In T121954#1892201, @gerritbot wrote:

Change 260168 had a related patch set uploaded (by Catrope):
Add secondary link to Flow board for flow-thanks notifications

https://gerrit.wikimedia.org/r/260168

more-padding-maybe.png (85×433 px, 10 KB)

They probably shouldn't be that close together; filed T121955: Put more space between adjacent category links for that.

Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Dec 19 2015, 12:54 AM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Dec 21 2015, 4:36 PM
gerritbot added a comment.Dec 21 2015, 4:39 PM

Change 260168 merged by jenkins-bot:
Add secondary link to Flow board for flow-thanks notifications

https://gerrit.wikimedia.org/r/260168

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 21 2015, 5:00 PM
Etonkovidova subscribed.Jan 26 2016, 11:06 PM

Checked locally and on test.wikipedia.

Screen Shot 2016-01-26 at 3.01.23 PM.png (334×575 px, 51 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Jan 26 2016, 11:29 PM
• jmatazzoni subscribed.Feb 11 2016, 8:29 PM

Re. the narrow issue, yes, the secondary link to the Talk page is present.

Re. the Thank message overall, the form is incorrect. The message should not include the pagename (which was moved to the secondary link)

Closing ticket.

• jmatazzoni closed this task as Resolved.Feb 11 2016, 8:29 PM
• jmatazzoni set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL