Page MenuHomePhabricator

Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them
Closed, ResolvedPublic

Description

RevisionDelete is "Change visibility of selected revisions". The scenarios/test areas only involve this if specifically stated.

Test areas

Test plans

  • Create wikitext -> Delete wikitext page -> Enable Flow -> Delete Flow board -> Restore only wikitext revision with checkbox -> Restore Flow with checkbox
  • Create as Flow -> Delete Flow -> Create as wikitext -> Delete wikitext -> Create as wikitext -> Undelete both together (since the top-level page after restoration is wikitext, you have to query flow_workflow on workflow_namespace and workflow_title_text to see if the workflow_page_id matches the restored page)
  • After the one immediately above, delete all revisions, undelete Flow board.
  • Create wikitext -> delete wikitext -> create Flow -> delete Flow -> restore both together
  • Create wikitext page -> delete wikitext page -> undelete deleted wikitext page -> deleted undeleted wikitext page again -> create new Flow page where wikitext page was ->undelete wikitext page where Flow page is now -> delete all revisions -> undelete wikitext.
  • Create Flow page -> delete Flow page -> undelete deleted Flow page -> deleted undeleted Flow page again -> create new wikitext page where Flow page was ->undelete Flow page where wikitext page is now -> delete all revisions -> undelete Flow
  • Create wikitext -> delete wikitext -> create Flow -> restore wikitext (T104591: Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page)
  • [RevisionDelete] Create wikitext page -> delete page -> create Flow board -> delete page -> hide Flow revision using RevisionDelete -> unhide Flow revision using RevisionDelete -> undelete Flow revision
  • [RevisionDelete] Create Flow board -> delete page -> create wikitext page -> undelete Flow board -> hide Flow revision using RevisionDelete -> delete page -> undelete only Flow revision
    • With "Remove restrictions on restored revisions" unchecked (should fail)
    • With "Remove restrictions on restored revisions" checked (should work and show only Flow)
  • Create Flow, delete Flow, create Flow with EnableFlow. Go to undelete screen, click the timestamp to go to the board, and try to post. Restore the old Flow board. Get revision ID of revision.rev_id for old board (from DB or api.php prop=revisions). Add ?oldid=123 to the URL, but replacing 123 with the revision ID from before. Try to post to the board.
  • Etc.

It's okay to reject some of these operations (e.g. revision deletion) as long as we end up in a consistent state.

See https://en.wikipedia.org/wiki/Wikipedia_talk:Flow/Archive_14#Can_we_please_get_rid_of_it_.28oh_wait.2C_I_already_did.29 .

After these scenarios are developed, they should be tested and issues fixed as part of T122262: Improve Flow deletion/undeletion resilience.

Event Timeline

Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

Tested following scenarios:

  • Delete wikitext page: ok
  • Delete Flow page: ok
  • Restore deleted wikitext page: ok
  • Restore deleted Flow page: ok
  • Delete restored wikitext page again: ok
  • Delete restored Flow page again: ok
  • Create new Flow page where wikitext page used to be: ok
  • Create new Flow page where Flow page used to be: ok
  • Delete Flow page where wikitext page was: ok
  • Delete Flow page where Flow page was: ok
  • Restore original wikitext page: ok
  • Restore original Flow page: ok
matthiasmullie closed this task as Resolved.Mar 16 2016, 3:41 PM
matthiasmullie claimed this task.

Thanks, @matthiasmullie . Added variants of those scenarios to the description.

Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF updated the task description. (Show Details)