Page MenuHomePhabricator
Create Task
Maniphest T122365

Fix "About this article" footer RTL compliance
Closed, ResolvedPublic
Actions

Description

  • Cell text alignment based on writing direction of article's language if the strings are localized in the article's language.

Note: will need RTL translations to see this affect.

Related Objects
Search...

Event Timeline

• BGerstle-WMF created this task.Dec 23 2015, 10:28 PM
• BGerstle-WMF assigned this task to Mhurd.
• BGerstle-WMF raised the priority of this task from to Medium.
• BGerstle-WMF updated the task description. (Show Details)
• BGerstle-WMF added projects: I18n, RTL, Wikipedia-iOS-App-Backlog, iOS-app-v5-production.
• BGerstle-WMF added subscribers: Mooeypoo, Mhurd, StudiesWorld and 3 others.
Mhurd edited projects, added Wikipedia-iOS-App-Development; removed Wikipedia-iOS-App-Backlog.Jan 13 2016, 3:58 PM
Mhurd set Security to None.
Mhurd moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.
• BGerstle-WMF mentioned this in T121679: Fix Search RTL compliance.Jan 13 2016, 9:42 PM
• BGerstle-WMF mentioned this in T121680: Fix recent pages RTL compliance.
Mhurd added a comment.Jan 13 2016, 10:18 PM

https://github.com/wikimedia/wikipedia-ios/pull/378

Mhurd moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.Jan 13 2016, 10:18 PM
Mhurd mentioned this in rAPIOSeb843debac0a: Merge branch 'master' into feature/T122365/footer-menu-rtl.Jan 14 2016, 7:10 PM
• Fjalapeno mentioned this in rAPIOS055e8981cac7: Merge pull request #378 from wikimedia/feature/T122365/footer-menu-rtl.Jan 14 2016, 8:39 PM
Mhurd moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Jan 14 2016, 8:41 PM
• BGerstle-WMF added a comment.Feb 9 2016, 3:34 PM

Verified 5.0.0.679

iPhone 6 iOS 9.2

Screen Shot 2016-02-09 at 10.24.10 AM.png (1×750 px, 366 KB)

iPad 3 iOS 8.3:

Screen Shot 2016-02-09 at 10.33.48 AM.png (1×2 px, 810 KB)

• BGerstle-WMF moved this task from Needs QA to Needs Design Review on the Wikipedia-iOS-App-Development board.Feb 9 2016, 3:34 PM
• BGerstle-WMF added a subscriber: • Nirzar.EditedFeb 9 2016, 3:53 PM

Ping @Nirzar, please review above screencaps and/or "about this article" footer in app when RTL

• Nirzar moved this task from Needs Design Review to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Feb 11 2016, 11:30 PM
• JMinor closed this task as Resolved.Feb 18 2016, 11:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL