Page MenuHomePhabricator
Create Task
Maniphest T122907

[Regression] Special:EmailUser and Special:ExpandTemplates broken after OOUI conversion
Closed, ResolvedPublic
Actions

Description

Filing here as reminder for the next wmf branch.

Unbreak Now:

Low prio:

Details

SubjectRepoBranchLines +/-
Fix Special:EmailUsermediawiki/coremaster+30 -30
SpecialComparePages: Float the boxes, if available space is givenmediawiki/coremaster+24 -0
SpecialExpandTemplates: Fix false checkbox label for nowiki tagmediawiki/coremaster+5 -5
Fix false message output method on Special:ExpandTemplatesmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jan 5 2016, 7:35 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Regression, MediaWiki-User-Interface, MediaWiki-Special-pages.
Krinkle added subscribers: Krinkle, Reedy, Florian.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 5 2016, 7:35 PM
Florian claimed this task.Jan 5 2016, 8:31 PM
Florian triaged this task as High priority.
Florian set Security to None.
gerritbot subscribed.Jan 5 2016, 8:31 PM

Change 262589 had a related patch set uploaded (by Florianschmidtwelzow):
Fix Special:EmailUser

https://gerrit.wikimedia.org/r/262589

gerritbot added a project: Patch-For-Review.Jan 5 2016, 8:31 PM

Change 262590 had a related patch set uploaded (by Florianschmidtwelzow):
Fix false message output method on Special:ExpandTemplates

https://gerrit.wikimedia.org/r/262590

gerritbot added a comment.Jan 5 2016, 8:32 PM

Change 262592 had a related patch set uploaded (by Florianschmidtwelzow):
SpecialComparePages: Float the boxes, if available space is given

https://gerrit.wikimedia.org/r/262592

Krinkle updated the task description. (Show Details)Jan 6 2016, 7:31 PM
gerritbot added a comment.Jan 6 2016, 7:38 PM

Change 262590 merged by jenkins-bot:
Fix false message output method on Special:ExpandTemplates

https://gerrit.wikimedia.org/r/262590

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 6 2016, 8:00 PM
MGChecker moved this task from To triage to Passwords/Email on the MediaWiki-Special-pages board.Jan 7 2016, 7:29 PM
MGChecker added a project: MediaWiki-Email.Jan 7 2016, 7:41 PM
MGChecker moved this task from Passwords/Email to SpecialPage system on the MediaWiki-Special-pages board.
TTO subscribed.Jan 8 2016, 6:22 AM

On Special:ExpandTemplates, the checkbox that is supposed to say "Suppress <nowiki> tags in result" is saying "Suppress tags in result".

gerritbot added a comment.Jan 8 2016, 6:28 AM

Change 263037 had a related patch set uploaded (by Florianschmidtwelzow):
SpecialExpandTemplates: Fix false checkbox label for nowiki tag

https://gerrit.wikimedia.org/r/263037

Krinkle raised the priority of this task from High to Unbreak Now!.Jan 8 2016, 10:28 PM
gerritbot added a comment.Jan 11 2016, 6:36 PM

Change 263037 merged by jenkins-bot:
SpecialExpandTemplates: Fix false checkbox label for nowiki tag

https://gerrit.wikimedia.org/r/263037

Jdlrobson subscribed.Jan 11 2016, 6:41 PM

Remaining patches:
https://gerrit.wikimedia.org/r/#/c/262592/

Florian added a comment.Jan 11 2016, 6:57 PM

One of these both would be more important:
https://gerrit.wikimedia.org/r/#/c/262589/
or
https://gerrit.wikimedia.org/r/#/c/263227/

to unbreak Special:EmailUser.

matmarex updated the task description. (Show Details)Jan 11 2016, 9:05 PM
matmarex updated the task description. (Show Details)Jan 11 2016, 9:11 PM
gerritbot added a comment.Jan 12 2016, 12:07 AM

Change 262592 merged by jenkins-bot:
SpecialComparePages: Float the boxes, if available space is given

https://gerrit.wikimedia.org/r/262592

gerritbot added a comment.Jan 12 2016, 12:25 AM

Change 262589 abandoned by Bartosz Dziewoński:
Fix Special:EmailUser

Reason:
The change this is a follow-up to was reverted instead. Please squash and resubmit them both :)

https://gerrit.wikimedia.org/r/262589

matmarex closed this task as Resolved.Jan 12 2016, 12:27 AM
matmarex updated the task description. (Show Details)
matmarex removed a project: Patch-For-Review.
matmarex mentioned this in T117791: Convert Special:EmailUser to OOUI.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL