Page MenuHomePhabricator
Create Task
Maniphest T122910

Link/Mention inspector: 'Uncaught Type Error' if the link inspector Edit is not explicitly closed/dismissed
Closed, ResolvedPublic
Actions

Description

First scenario:

  1. Type a phrase, then convert it to an external link.
  2. Save the post.
  3. Open the post for editing and click the previously inserted link to edit it.
  4. Without closing the link inspector, click on 'Save changes'.

It hangs, not responding to anything except refreshing the page.
The stack trace is unusually long:

Uncaught TypeError: Cannot read property 'focus' of undefinedve.ce.Surface.focus Uncaught TypeError: Cannot read property 'top' of undefined

Uncaught TypeError: Cannot read property 'ownerDocument' of undefined
Sizzle.contains
OO.ui.contains
ve.ce.Surface.showSelectionState
ve.ce.Surface.showModelSelection
ve.ce.Surface.onModelSelect
ve.ce.Surface.activate
(anonymous function)
(anonymous function)
fire
self.fireWith
deferred.(anonymous function)
(anonymous function)
fire
self.add
promise.always
OO.ui.WindowManager.closeWindow
OO.ui.WindowManager.removeWindows
OO.ui.WindowManager.clearWindows
OO.ui.WindowManager.destroy
ve.ui.LinearContext.destroy
ve.ui.Surface.destroy
ve.init.Target.clearSurfaces
ve.init.Target.destroy
mw.flow.ui.VisualEditorWidget.destroy
mw.flow.ui.EditorSwitcherWidget.destroy
mw.flow.ui.EditorWidget.destroy
mw.flow.ui.EditPostWidget.destroy
(anonymous function)
oo.EventEmitter.emit
(anonymous function)
(anonymous function)
fire
self.fireWith
(anonymous function)
fire
self.fireWith
deferred.(anonymous function)
fire
self.fireWith
(anonymous function)
fire
self.fireWith
(anonymous function)
deferred.(anonymous function)
(anonymous function)
fire
self.fireWith
done
callback

Scenario 2 (a milder case - it does not hang)

  1. Insert an external link - not word(s), just a link. Save.
  2. Re-open the post for editing - click on the link to edit.
  3. Without closing the link inspector - click on 'Save changes'

The following is displayed, but the post is saved and all windows are closed properly.

Uncaught TypeError: Cannot read property 'focus' of undefined
Uncaught TypeError: Cannot read property 'top' of undefined

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e673ad6de)mediawiki/extensions/VisualEditormaster+1 -1
ce.Surface: Don't attempt to activate a disabled surfaceVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 5 2016, 7:47 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 5 2016, 7:47 PM
Catrope moved this task from Untriaged to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.Jan 19 2016, 3:05 AM
• jmatazzoni edited projects, added Collab-Team-2016-Apr-Jun-Q4; removed Collaboration-Team-Archive-2015-2016.Apr 5 2016, 5:14 PM
Etonkovidova updated the task description. (Show Details)Apr 18 2016, 10:09 PM
Etonkovidova triaged this task as High priority.Apr 18 2016, 10:12 PM
Etonkovidova added a comment.Apr 18 2016, 10:17 PM

Re-checked(Chrome)- the issue is still present in betalabs. The console also shows 414 (Request-URI Too Large) along with the previous errors.
Another screenshot for the broken Link inspector

Screen Shot 2016-04-18 at 3.08.56 PM.png (302×785 px, 34 KB)

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 18 2016, 10:25 PM
• jmatazzoni moved this task from Ready for Pickup to In Development on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 19 2016, 1:13 AM
Catrope moved this task from In Development to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 19 2016, 5:15 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 5:15 PM
• jmatazzoni moved this task from Ready for Pickup to Untriaged on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 11 2016, 9:21 PM
• jmatazzoni edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collab-Team-2016-Apr-Jun-Q4.Jul 12 2016, 4:38 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-Q1-July-Sep-2016 board.
Etonkovidova added a comment.EditedJul 18 2016, 11:11 PM

Re-checked the scenarios
(1) scenario displays: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined

(2) scenario displays: Uncaught TypeError: Cannot read property 'appendHighlights' of null

Additionally, inserting Mention and clicking to edit it and clicking on 'Save changes' without closing edit Mention inspector, gives the same error as in (2) scenario.

Etonkovidova renamed this task from Link inspector: 'Uncaught Type Error' if the link inspector Edit is not explicitly closed/dismissed to Link/Mention inspector: 'Uncaught Type Error' if the link inspector Edit is not explicitly closed/dismissed.Jul 18 2016, 11:13 PM
Etonkovidova added a comment.Sep 29 2016, 10:32 PM

Re-checked - the issue is still present.

• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collab-Team-Q1-July-Sep-2016.Sep 29 2016, 11:05 PM
• jmatazzoni moved this task from Untriaged to Flow Holding Area on the Collaboration-Team-Triage board.
gerritbot subscribed.Apr 26 2018, 3:02 PM

Change 429209 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] ce.Surface: Don't attempt to activate a disabled surface

https://gerrit.wikimedia.org/r/429209

gerritbot added a project: Patch-For-Review.Apr 26 2018, 3:02 PM
Jdforrester-WMF added projects: VisualEditor-EditingTools, VisualEditor (Current work).Apr 26 2018, 3:11 PM
gerritbot added a comment.Apr 27 2018, 8:16 PM

Change 429209 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.Surface: Don't attempt to activate a disabled surface

https://gerrit.wikimedia.org/r/429209

gerritbot added a comment.Apr 27 2018, 9:48 PM

Change 429526 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e673ad6de)

https://gerrit.wikimedia.org/r/429526

Jdforrester-WMF assigned this task to Esanders.Apr 27 2018, 10:40 PM
Jdforrester-WMF moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Apr 29 2018, 1:13 PM

Change 429526 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e673ad6de)

https://gerrit.wikimedia.org/r/429526

Esanders mentioned this in T193103: Switching to VE from NWE while keeping the link inspector/Add Citation dialog open throws error "Uncaught TypeError: Cannot read property 'model' of undefined".Apr 30 2018, 10:23 AM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 30 2018, 5:14 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)); removed Patch-For-Review.Apr 30 2018, 5:33 PM
• Deskana closed this task as Resolved.May 14 2018, 1:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL